also looking at this
test(pg): make the Postgres-gated tests actually run in CI
#1077
4 files
+68
-35
| @@ -0,0 +1,55 @@ | ||
| 1 | /** | |
| 2 | * The Postgres a gated test should connect to, and whether it is reachable. | |
| 3 | * | |
| 4 | * Several tests can only be written against a real pooled driver — the | |
| 5 | * transaction data leak (#1065), the migration lock (#1067), the ORM | |
| 6 | * integration pass (#1038) — so they gate on a live server and skip without | |
| 7 | * one. That gate was quietly wrong in CI. | |
| 8 | * | |
| 9 | * Each of those files built its own URL as | |
| 10 | * `postgres://${process.env.USER}@localhost:5432/postgres`, which describes a | |
| 11 | * developer machine: a peer-authenticated server owned by the current user, | |
| 12 | * no password. CI is not that. It starts Postgres 17 as a service with | |
| 13 | * `POSTGRES_USER=postgres`, `POSTGRES_PASSWORD=postgres`, `POSTGRES_DB=test_db` | |
| 14 | * and exports `DATABASE_URL`. On a runner, `process.env.USER` is `runner`, so | |
| 15 | * every probe failed with | |
| 16 | * | |
| 17 | * FATAL: password authentication failed for user "runner" | |
| 18 | * | |
| 19 | * the gate read that as "no Postgres here", and the tests SKIPPED. CI stayed | |
| 20 | * green while the guards for the two most severe bugs in the release never | |
| 21 | * ran at all — the worst shape for a test to be in, because the green tick | |
| 22 | * says the opposite. | |
| 23 | * | |
| 24 | * So: prefer what the environment tells us, fall back to the local shape. | |
| 25 | */ | |
| 26 | ||
| 27 | import { SQL } from 'bun' | |
| 28 | import process from 'node:process' | |
| 29 | ||
| 30 | export const PG_URL: string | |
| 31 | = process.env.DATABASE_URL | |
| 32 | ?? process.env.POSTGRES_URL | |
| 33 | ?? `postgres://${process.env.USER ?? 'postgres'}@localhost:5432/postgres` | |
| 34 | ||
| 35 | /** | |
| 36 | * Whether that server actually answers. | |
| 37 | * | |
| 38 | * A function rather than an awaited constant so this module needs no top-level | |
| 39 | * await: the rule against it exists to keep one out of the shipped bundle, and | |
| 40 | * suppressing it in a helper to save three callers one line each is a poor | |
| 41 | * trade. Callers await it at the top of their own `.test.ts`, where the rule | |
| 42 | * does not apply. The URL above is the part that was wrong and the part worth | |
| 43 | * sharing; this is three lines of probe. | |
| 44 | */ | |
| 45 | export async function probePostgres(): Promise<boolean> { | |
| 46 | try { | |
| 47 | const probe = new SQL(PG_URL) | |
| 48 | await probe.unsafe('SELECT 1') | |
| 49 | await probe.end() | |
| 50 | return true | |
| 51 | } | |
| 52 | catch { | |
| 53 | return false | |
| 54 | } | |
| 55 | } | |