ReviewOS

also looking at this

stacks/bun-query-builder

feat(types): export QueryBuilderOptions, the shape an app actually writes

#1063
Closed glennmichael123 wants to merge feat/query-builder-options into main
2 files +68 -6

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/bun-query-builder/src/types.tsmodified+4-1
Changes to packages/bun-query-builder/src/types.ts
@@ -459,7 +459,10 @@ export interface QueryBuilderConfig {
459459 * still demand a complete `TimestampConfig` from anyone who wanted to rename a
460460 * single column.
461461 */
462export type DeepPartial<T> = T extends (...args: any[]) => any
462// `_args`, not `args`: this is a type-level signature, so the parameter name is
463// required syntax with nothing that could ever reference it. pickier's
464// no-unused-vars flags it all the same, and `^_` is the pattern it exempts.
465export type DeepPartial<T> = T extends (..._args: any[]) => any
463466 ? T
464467 : T extends readonly (infer U)[]
465468 ? readonly U[]