ReviewOS

stacks/bun-query-builder

hooks: native SQL metadata loss in 0.2.69 (duplicate of #1142)

#1145
Closed glennmichael123 opened this 8 days ago ·
8 days ago

Correction and disposition

This is a duplicate of #1142, not a missing-callback defect. The original investigation counted callbacks whose event.sql contained the probe marker. On the native drivers the callbacks fired, but event.sql was [object Promise], so the marker counter incorrectly reported zero callbacks.

Rechecked on September 15 with Bun 1.4.2 and published bun-query-builder 0.2.69, using explicit disposable local database URLs and capturing every event without filtering:

DriverOutside transactionInside transaction
SQLiteSELECT text, params [7]SELECT text, params [8]
PostgreSQL 16[object Promise], no params[object Promise], no params
MySQL 8.4.5[object Promise], no params[object Promise], no params

Each driver emitted two onQueryEnd events. All queries executed successfully. No real application database was used.

The existing source fix is e8d66ca, already recorded in #1142. I verified an isolated checkout of current main, 17ac15f, today:

  • client.network-query-hooks.test.ts: 2 pass, both MySQL and PostgreSQL enabled. Covers parameterized SQL, bindings, transactions, reserved connections, errors, slow hooks and spans.
  • client.cache-isolation.test.ts and client.transaction-completion.test.ts: 8 pass, including both SQLite modes, MySQL and PostgreSQL.
  • Existing upstream CI run 34692187993 completed successfully.

No additional implementation is needed for this duplicate. This does not mean published 0.2.69 contains the fix; no release or dependency replacement was performed. Stacks #2629 remains a separate facade transaction-connection fix.

8 days ago

Closing as a duplicate of #1142. Corrected the body with unfiltered event evidence and verification of the existing main-branch fix; the previous zero-callback diagnosis was my probe error. Published 0.2.69 is still affected until a release includes e8d66ca.

Sign in to comment on this issue.