ReviewOS

stacks/bun-query-builder

Committed SQLite artifacts and a broken root qbx shim

#1072
Closed glennmichael123 opened this 22 days ago · 0 comments
22 days ago

Two small things, both tracked in git and both harmless-but-wrong.

other.db, other.db-shm, other.db-wal are committed SQLite test artifacts (~36KB), added accidentally in 81e6b40 fix(cli): fall back to the configured dialect before defaulting to postgres. .gitignore covers packages/benchmark/benchmark.db-shm and -wal but nothing at the repo root, so the root pair slipped through. Remove them and extend the ignore to *.db, *.db-shm, *.db-wal.

The root qbx is a broken two-line shim, added in 2733193 chore: wip:

#!/usr/bin/env bun
import('./bin/cli')

There is no bin/ at the repo root — the CLI lives at packages/bun-query-builder/bin/cli.ts — so it fails:

$ bun qbx --help
error: Cannot find module './bin/cli' from '.../bun-query-builder/qbx'

It also isn't executable, so the shebang never applies. .gitignore already covers bin/qbx and packages/bun-query-builder/bin/qbx, just not this one. It should be deleted, or repointed at ./packages/bun-query-builder/bin/cli.ts if a root-level entry point is wanted.

Neither affects the published package — files is ["README.md", "dist"] — so this is repo tidiness only.

Found while auditing after #1001.

Sign in to comment on this issue.