ReviewOS

stacks/bun-git-hooks

The `staged-lint` command depends on ESLint

#56
Open filipfalcon opened this 8 days ago ·
8 days ago

Describe the bug

When using built-in staged-lint with Biome it fails on ESLint configuration missing:

johndoe@Johns-MacBook-Air project % git commit -S -m "chore: update dependencies"
[ERROR] Command stderr:
Oops! Something went wrong! :(

ESLint: 9.39.1

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.


[ERROR] Command failed: bunx --bun eslint --fix
[ERROR] Failed on files: project/src/index.ts
[ERROR] Command failed: bunx --bun tsc --noEmit
[ERROR] Failed on files: project/src/index.ts
 ERROR  Staged lint failed
error: "git-hooks" exited with code 1

The configuration:

"git-hooks": {
  "pre-commit": {
    "staged-lint": {
      "*.{js,ts,json,jsonc,cjs,mjs}": "biome check --fix"
    }
  },
  "commit-msg": "bun commitlint --edit $1"
},

Reproduction

Configuration provided above.

System Info

System:
    OS: macOS 26.0.1
    CPU: (8) arm64 Apple M2
    Memory: 173.56 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.14.0 - /Users/johndoe/.nvm/versions/node/v22.14.0/bin/node
    Yarn: 1.22.22 - /Users/johndoe/.nvm/versions/node/v22.14.0/bin/yarn
    npm: 10.9.2 - /Users/johndoe/.nvm/versions/node/v22.14.0/bin/npm
    pnpm: 10.10.0 - /Users/johndoe/.nvm/versions/node/v22.14.0/bin/pnpm
    bun: 1.2.23 - /Users/johndoe/.bun/bin/bun
    Deno: 2.2.6 - /Users/johndoe/.deno/bin/deno
  Browsers:
    Chrome: 141.0.7390.123
    Safari: 26.0.1

Used Package Manager

bun

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Sign in to comment on this issue.