ReviewOS

also looking at this

stacks/buddy

test: measure coverage, and call the three files nothing called

#1442
Merged glennmichael123 wants to merge test/zero-called-files into main
4 files +210 -0
9 days ago

The coverage item from the punch list, done data-first: bun test --coverage (exposed as a test:coverage script) reports 88.2% mean line coverage across 140 source files — considerably healthier than the audit's "no coverage measurement exists" note implied — and pointed at exactly three files with 0% function coverage: modules the suite never once invoked.

FileWhy it mattersNow pinned
src/utils/pantry-parser.tswired into the package scanner — a regression means pantry.lock silently vanishes from the dashboardextraction, entries missing name/version, no-packages lock, malformed JSON → null
src/security/loader.tsthe front door of every buddy security audit (audit() starts with it); the six rules are tested against hand-built fixtures, so a discovery bug would fail every real audit while every test stayed greenyml+yaml discovered, everything else ignored, subdirectories not traversed (GitHub loads only top-level files), workflow-less repo → []
src/analysis/analyzers/github-actions.tsthe wrapper review actually calls around the tested ruleserror→major severity mapping, whole-repo audit filtered to changed files only, files: [] short-circuits without auditing

bun test: 2249 pass / 0 fail (+12); typecheck and pickier green.

Remaining from the deep list after this: the worst partially-covered files (registry-client, github-provider, buddy.ts at 32–56% lines) are big-integration territory, and the dogfood-published-package blind spot is a security-vs-coverage design call worth discussing before touching.

🤖 Generated with Claude Code

4 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.