ReviewOS

also looking at this

stacks/buddy

fix: give GitLab/Bitbucket pipelines the review job, and stop cleanup lying

#1432
Merged glennmichael123 wants to merge fix/pipelines-and-cleanup into main
5 files +152 -8
test/ci-template-review.test.tsadded+55-0
Changes to test/ci-template-review.test.ts
@@ -0,0 +1,55 @@
1import { afterEach, beforeEach, describe, expect, it } from 'bun:test'
2import { promises as fs } from 'node:fs'
3import { tmpdir } from 'node:os'
4import { join } from 'node:path'
5import { generateCoreWorkflows, getWorkflowPreset } from '../src/setup'
6import { Logger } from '../src/utils/logger'
7
8/**
9 * `ciTemplateFor` took a `{ review }` option and its only call site never
10 * passed it, so a GitLab or Bitbucket repository set up by `buddy setup` got
11 * a pipeline that scheduled updates and never reviewed a merge request. The
12 * GitHub workflow has always carried the review job.
13 */
14describe('generated GitLab and Bitbucket pipelines', () => {
15 let dir: string
16 let originalCwd: string
17
18 beforeEach(async () => {
19 dir = await fs.mkdtemp(join(tmpdir(), 'buddy-pipeline-'))
20 originalCwd = process.cwd()
21 process.chdir(dir)
22 })
23
24 afterEach(async () => {
25 process.chdir(originalCwd)
26 await fs.rm(dir, { recursive: true, force: true })
27 })
28
29 it('success case - the GitLab pipeline carries the review job', async () => {
30 await generateCoreWorkflows(
31 getWorkflowPreset('standard'),
32 { owner: 'group', name: 'repo', provider: 'gitlab' },
33 false,
34 Logger.silent(),
35 )
36
37 const pipeline = await fs.readFile(join(dir, '.gitlab-ci.yml'), 'utf-8')
38
39 expect(pipeline).toContain('buddy:review:')
40 expect(pipeline).toContain('buddy review $CI_MERGE_REQUEST_IID')
41 })
42
43 it('success case - the Bitbucket pipeline carries the review step', async () => {
44 await generateCoreWorkflows(
45 getWorkflowPreset('standard'),
46 { owner: 'workspace', name: 'repo', provider: 'bitbucket' },
47 false,
48 Logger.silent(),
49 )
50
51 const pipeline = await fs.readFile(join(dir, 'bitbucket-pipelines.yml'), 'utf-8')
52
53 expect(pipeline).toContain('buddy review $BITBUCKET_PR_ID')
54 })
55})