ReviewOS

also looking at this

stacks/buddy

fix(dashboard): read the include toggles and the enabled switch

#1430
Merged glennmichael123 wants to merge fix/dashboard-toggles into main
5 files +100 -2
9 days ago

Four dashboard keys, all declared, all documented with defaults, none read.

The three include* toggles

includePackageJson, includeDependencyFiles, includeGitHubActions — in the feature page's defaults table as true, in its example config, and consumed by nothing. Every ecosystem was always listed whatever the config said.

generateDashboard now takes all three and filters the detected dependencies before the section renders; createOrUpdateDashboard passes them through beside the show* toggles it already honoured. Each toggle drops exactly its own section — there's a test per toggle, and one for all three off.

enabled — honoured as an explicit false only

Documented as defaulting to false; gated nothing.

Enforcing that default literally would switch the dashboard off for every repository that never wrote a dashboard block — the same trap ai.review.enabled set in #1406, and resolved the same way: unset means "not configured", never "off." The docs table now reads:

| enabled | boolean | true | Set to false to stop the dashboard being created or refreshed |

Checked in the two production paths that create or refresh the issue: the dashboard command, and the post-merge refresher from #1425. The refresher reports it as a skip through the post-merge outcome rather than returning silently, so a maintainer who disabled the dashboard and configured refreshDashboard sees the two settings disagree.

Tests

2148 → 2153.

Lint ✓ · typecheck ✓ · check:docs ✓ · 0 fail

🤖 Generated with Claude Code

https://claude.ai/code/session_01UWouahBJT3msK7V2VDYY6T

5 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.