fix(gitlab): read a job trace as text, so ciLogs is not a lie

test/ci-runs.test.tsmodified+45-0

Changes to test/ci-runs.test.ts

		⋯208 linesShow the 208 lines above this hunk@@ -209,3 +209,48 @@ describe('re-running a failed run', () => {
209	209	expect(await gitlab().rerunWorkflowRun(77)).toBe(false)
210	210	})
211	211	})
	212	+
	213	+/**
	214	+ * GitLab declared `ciLogs: true` and could not return a log. `optional` did
	215	+ * not pass `raw`, so the transport ran `JSON.parse` over a plain-text job
	216	+ * trace, threw, and the catch reported that as "no logs" — making `buddy
	217	+ * fix-ci` on GitLab answer "could not read the run logs" every single time.
	218	+ */
	219	+describe('reading a job log', () => {
	220	+ it('success case - gitlab returns the plain-text trace', async () => {
	221	+ const TRACE = `$ bun install\nerror: lockfile had changes, but lockfile is frozen\n`
	222	+
	223	+ globalThis.fetch = (async () => new Response(TRACE, {
	224	+ status: 200,
	225	+ headers: { 'content-type': 'text/plain' },
	226	+ })) as unknown as typeof fetch
	227	+
	228	+ expect(await gitlab().getWorkflowRunLogs(77)).toBe(TRACE)
	229	+ })
	230	+
	231	+ it('success case - asks for the job trace, not the pipeline', async () => {
	232	+ const urls: string[] = []
	233	+ globalThis.fetch = (async (input: string) => {
	234	+ urls.push(String(input))
	235	+ return new Response('log text', { status: 200 })
	236	+ }) as unknown as typeof fetch
	237	+
	238	+ await gitlab().getWorkflowRunLogs(77)
	239	+
	240	+ expect(urls[0]).toContain('/jobs/77/trace')
	241	+ })
	242	+
	243	+ it('edge case - a missing job reads as no log rather than an error', async () => {
	244	+ globalThis.fetch = (async () => new Response('', { status: 404 })) as unknown as typeof fetch
	245	+
	246	+ expect(await gitlab().getWorkflowRunLogs(77)).toBeNull()
	247	+ })
	248	+
	249	+ it('success case - a trace that happens to be JSON is still returned verbatim', async () => {
	250	+ // The bug was parsing at all. A trace whose first line is JSON must not
	251	+ // come back as an object.
	252	+ globalThis.fetch = (async () => new Response('{"step":"install"}', { status: 200 })) as unknown as typeof fetch
	253	+
	254	+ expect(await gitlab().getWorkflowRunLogs(77)).toBe('{"step":"install"}')
	255	+ })
	256	+})