ReviewOS

also looking at this

stacks/buddy

fix: prevent generated dependency cache PRs

#1366
Merged chris wants to merge codex/prevent-generated-pantry-prs into main
16 files +356 -72
9 days ago

Summary

  • exclude installed and generated dependency trees such as pantry, ts-pantry, vendor, and node_modules from both package discovery paths
  • reject update file changes when the target does not exist on the base branch
  • escape compound version ranges in Markdown tables and URL-encode version path segments
  • normalize compare ranges and keep release selection within the requested target

Root cause

Buddy scanned ignored Pantry cache manifests as project-owned package files. The package lookup then selected one of those generated manifests, and the Git provider silently treated a missing update target as a new file. Compound peer ranges also introduced raw table delimiters and invalid compare URLs into the PR body.

Impact

Dependency PRs can no longer create generated Pantry paths that do not exist on the base branch. PR bodies remain valid when current versions are compound semver ranges.

Validation

  • bun test (708 passing)
  • bun run typecheck
  • bun run build
  • targeted Pickier lint on all changed files

The repository-wide Pickier run still reports the pre-existing CHANGELOG.md heading-level error plus three existing documentation warnings.

16 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.