ReviewOS

also looking at this

stacks/better-dx

fix(deps): move from buddy-bot to @buddysh/buddy

#966
Merged glennmichael123 wants to merge fix/buddy-rename into main
6 files +23 -21
9 days ago

Closes #965.

buddy-bot was renamed to @buddysh/buddy. The old name is frozen at the final pre-rename build and carries no deprecation notice, so it still looks maintained:

PackageLatestPublished
buddy-bot0.10.52026-08-19 — registry untouched since
@buddysh/buddy0.11.22026-09-29

Because this package depends on it, every better-dx consumer installs the abandoned build. That has already cost a downstream repo: 0.10.5 predates the deps.yaml fix in 0.11.2 (stacksjs/buddy#1453) and rewrote stacksjs/bun-query-builder's deps.yaml into text that no longer parses as YAML —

  postgres: ^18.6sqlite: latest`3.53.4

— swallowing the sqlite key and failing Setup Pantry before any job ran.

The rename moved more than the name

These have to go together, which is why this is more than a one-line bump:

  1. package.json — buddy-bot ^0.10.5 → @buddysh/buddy ^0.11.2
  2. .config/buddy-bot.ts → .config/buddy.ts — 0.11.2 resolves its config as buddy.ts, so the old filename is never read
  3. The config's import and type — BuddyBotConfig → BuddyConfig
  4. The nine bunx buddy-bot invocations in .github/workflows/buddy-bot.yml
  5. The branch check — the new default prefix is buddy/, so matching only buddy-bot/* would silently stop detecting the rebase checkbox
  6. The stale ### buddy-bot heading in docs/tools.md (its commands already used the new buddy bin), and the CLAUDE.md line

Item 2 is the one worth reviewing closely. Changing the dependency without renaming the config file leaves the tool running unconfigured with no error. Verified both directions in this checkout:

.config/buddy.ts      -> repository = {"owner":"stacksjs","name":"development","provider":"github"}
.config/buddy-bot.ts  -> repository = {"owner":"","name":"","provider":"github"}   # empty defaults

Deliberately left alone

Three buddy references are a different project — the Stacks runtime, which happens to share the name:

  • buddy.sh links in docs/sponsors.md
  • the @stacksjs/buddy reference in docs/showcase.md
  • the "Buddy Toolkit" section in .github/CONTRIBUTING.md

One pre-existing thing I did not touch

.config/buddy.ts declares repository: { owner: 'stacksjs', name: 'development' }, which looks left over from before this repo was renamed to better-dx. It is unrelated to the rename and changing it would move where the bot operates, so that felt like your call rather than mine. Happy to include it if you want.

Verification

  • bun install — lockfile has no buddy-bot entries and resolves @buddysh/buddy@0.11.2
  • bun --bun tsc --noEmit clean
  • bun x --bun pickier . clean
  • bun test — 8 pass, 1 skip, 1 todo, 0 fail
  • Workflow YAML parses, all 5 jobs intact
  • update-check, update, dashboard, scan and rebase all exist in the 0.11.2 CLI

I did not run any update, scan or dashboard command while testing — those open PRs and write issues.

🤖 Generated with Claude Code

6 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.