ReviewOS

also looking at this

stacks/bench-review

Adopt the hq-apps app conventions

#76
Merged glennmichael123 wants to merge chore/hq-apps-conventions into main
31 files +1656 -395
resources/components/Bench/ConfirmHost.stxmodified+14-3
Changes to resources/components/Bench/ConfirmHost.stx
@@ -117,7 +117,18 @@
117117 @click="$event.stopPropagation()"
118118 class="p-6 max-w-md w-full bg-white border border-gray-200 rounded-2xl shadow-xl"
119119 >
120 <h2 id="bench-confirm-title" class="font-semibold text-gray-900 text-lg" :text="confirmStore.title()"></h2>
120 {{--
121 The static text inside these four elements mirrors the confirm store's
122 own defaults ('Are you sure?' / 'Confirm' / 'Cancel'), and `:text`
123 overwrites it the moment the dialog is asked to open. It is NOT dead
124 markup: without it the static build ships an empty <h2> and two buttons
125 with no accessible name, which is both an a11y defect (a screen reader
126 announces an empty heading and two unlabelled buttons) and a
127 release-gate failure — scripts/validate-release.ts rejects an empty
128 primary heading, and scripts/validate-ui.ts rejects an icon-only button
129 with no name. Keep these in sync with resources/stores/confirm.ts.
130 --}}
131 <h2 id="bench-confirm-title" class="font-semibold text-gray-900 text-lg" :text="confirmStore.title()">Are you sure?</h2>
121132 <p id="bench-confirm-message" class="mt-2 text-gray-600 text-sm" :text="confirmStore.message()"></p>
122133 <div class="flex gap-3 justify-end mt-6">
123134 <button
@@ -125,14 +136,14 @@
125136 @click="confirmStore.dismiss()"
126137 class="px-4 py-2 font-medium text-gray-700 text-sm bg-white hover:bg-gray-50 border border-gray-300 rounded-lg transition-colors"
127138 :text="confirmStore.cancelLabel()"
128 ></button>
139 >Cancel</button>
129140 <button
130141 type="button"
131142 @click="confirmStore.accept()"
132143 class="px-4 py-2 font-medium text-sm text-white rounded-lg transition-colors"
133144 x-class="acceptClass()"
134145 :text="confirmStore.confirmLabel()"
135 ></button>
146 >Confirm</button>
136147 </div>
137148 </div>
138149</div>