ReviewOS
@if (!issue)

No such issue

stacks/analyticshq has no issue numbered 65.

@else

stacks/analyticshq

Avatar: initial fallback missed a failed image load (fixed in 1096139, component not adopted)

#65
Closed glennmichael123 opened this 9 days ago ·
9 days ago

Fixed the bug, did not adopt the component

Closing: the bug this issue was really about is fixed in 1096139, and adopting <Avatar> turned out to be both impossible and pointless.

The bug was real

of a server-side auth check and the signed-out branch is what renders at build time. It was verified in bughq instead, where the equivalent markup is emitted into dist/account.html. Worth knowing for any future change to this page: a green build does not mean this markup was exercised.

Also found while here

typecheck:views passes six --lib flags, and stx typecheck --lib does not accumulate — only the last takes effect, so in practice only types/vendor.d.ts is loaded. It passes clean today, so nothing is broken, but the other five files are not doing what the command implies and a future ambient declaration added to one of them will appear to be ignored.

Sign in to comment on this issue.