ReviewOS

also looking at this

reviewos/reviewos.org

fix: allow runtime arenas within a finite runner address budget

#7
Merged chris wants to merge codex/runner-virtual-address-budget into main
13 files +298 -12

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/ci.ymlmodified+33-1
Changes to .github/workflows/ci.yml
@@ -1001,6 +1001,35 @@ jobs:
10011001 runs-on: ubuntu-latest
10021002 timeout-minutes: 15
10031003
1004 # The normal app build renders database-backed server blocks. Give those
1005 # pages the same disposable Postgres schema as the test suite, rather than
1006 # silently weakening server-script failures or reading production data.
1007 services:
1008 postgres:
1009 image: postgres:17
1010 env:
1011 POSTGRES_USER: postgres
1012 POSTGRES_PASSWORD: postgres
1013 POSTGRES_DB: reviewos
1014 ports:
1015 - 5432:5432
1016 options: >-
1017 --health-cmd pg_isready
1018 --health-interval 10s
1019 --health-timeout 5s
1020 --health-retries 5
1021
1022 env:
1023 DB_CONNECTION: postgres
1024 DB_HOST: 127.0.0.1
1025 DB_PORT: '5432'
1026 DB_DATABASE: reviewos
1027 DB_USERNAME: postgres
1028 DB_PASSWORD: postgres
1029 APP_URL: https://reviewos.test
1030 STACKS_DEFAULT_ROUTES: none
1031 APP_KEY: base64:Zm9yLWNpLW9ubHktbm90LWEtcmVhbC1hcHAta2V5LXg9
1032
10041033 steps:
10051034 - uses: actions/checkout@v6
10061035
@@ -1035,8 +1064,11 @@ jobs:
10351064 - name: Install Dependencies
10361065 run: bun install --frozen-lockfile
10371066
1067 - name: Migrate the preview database
1068 run: DB_MIGRATIONS_PATH="$PWD/database/migrations" ./buddy migrate
1069
10381070 - name: Build
10391071 run: bun run build
10401072
10411073 - name: Publish Commit
1042 run: ./storage/framework/scripts/publish-commit
1074 run: bash ./storage/framework/scripts/publish-commit
docs/todo/09-checks-ci.mdmodified+2-0
Changes to docs/todo/09-checks-ci.md
@@ -1574,6 +1574,8 @@ gate, in order.
15741574
15751575 The mode it protects now runs real jobs - source, actions and secrets all reach the guest - so
15761576 this is a policy in front of something rather than in front of nothing.
1577- [x] Supply pull-request preview builds with a migrated, disposable Postgres database so database-backed server blocks build under the normal strict failure checks; invoke the tracked publication script through Bash.
1578
15771579- [x] Permit native build files under a bounded 32 GiB default: Android creates a 6 GiB device image and Xcode maps a 24 GiB sparse compilation cache. Real sparse-file regressions exercise the inherited kernel limit on macOS and Linux, including their different shell block units; explicit smaller operator limits remain enforced.
15781580
15791581- [x] CPU, memory, process, disk, output, and wall-time limits enforced outside the job
docs/todo/index.mdmodified+1-1
Changes to docs/todo/index.md
@@ -23,7 +23,7 @@ grows, so a phase getting *longer* while it is worked on is normal and honest.
2323| [06 - Search and explore](./06-search-explore.md) | Indexing, search, discovery | Complete (21/21) |
2424| [07 - Marketing and docs](./07-marketing-docs.md) | Landing page, documentation, self-hosting guide | Complete (59/59) |
2525| [08 - Migration](./08-migration.md) | Importing from GitHub and other forges | Done (16/16) |
26| [09 - Checks and CI](./09-checks-ci.md) | Checks, durable execution, runner providers, deployments | Started (133/134) |
26| [09 - Checks and CI](./09-checks-ci.md) | Checks, durable execution, runner providers, deployments | Started (134/135) |
2727| [10 - Federation](./10-federation.md) | AT Protocol identity: resolution, linking and OAuth sign-in | Complete (17/17) |
2828| [11 - Self-hosting and operations](./11-self-hosting-deploy.md) | Deployment, backups, upgrades, ops | Done (56/56) |
2929| [12 - The API and agents](./12-api-and-agents.md) | API parity, machine accounts, MCP, the CLI | Complete (30/30) |