ReviewOS

also looking at this

pantry-pm/pantry

fix(chrome): ship NSS's runtime providers and gate on a real render

#246
Open chris wants to merge fix/chrome-nss-runtime-modules into main
3 files +114 -2

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/scripts/linux-native-browser.tsmodified+2-1
Changes to .github/scripts/linux-native-browser.ts
@@ -88,7 +88,8 @@ try {
8888 // own Chrome) answers NSS's dlopen fallback for a provider the package left
8989 // out, and the page renders anyway. Require the loader to have initialised
9090 // softokn and its crypto provider from the installed package itself.
91 const initialised = [...rendered.stderr.matchAll(/calling init: (\S+)/g)].map(match => match[1]!)
91 // Whole lines: the gate's root path has spaces in it, on purpose.
92 const initialised = [...rendered.stderr.matchAll(/calling init: (.+)$/gm)].map(match => match[1]!.trim())
9293 const nss = initialised.filter(path => /\/lib(?:softokn3|freeblpriv3)\.so$/.test(path))
9394 proof.nssModules = [...new Set(nss)]
9495 for (const module of ['libsoftokn3.so', 'libfreeblpriv3.so']) {