ReviewOS

also looking at this

pantry-pm/pantry

fix: hydrate durable registry snapshots before serving writes

#244
Merged chris wants to merge codex/wildloop-registry-rollout into main
11 files +202 -35
packages/registry/src/storage/object-metadata.tsmodified+8-9
Changes to packages/registry/src/storage/object-metadata.ts
@@ -1,4 +1,5 @@
11import type { S3Client } from './aws-client'
2import { isS3ObjectNotFound } from './aws-client'
23import { InMemoryMetadataStorage } from './metadata'
34
45/**
@@ -15,6 +16,7 @@ import { InMemoryMetadataStorage } from './metadata'
1516 * snapshot from the bucket.
1617 */
1718export class ObjectMetadataStorage extends InMemoryMetadataStorage {
19 private hydrated = false
1820 private s3: S3Client
1921 private bucket: string
2022 private key: string
@@ -38,19 +40,13 @@ export class ObjectMetadataStorage extends InMemoryMetadataStorage {
3840 private async load(): Promise<void> {
3941 try {
4042 const buf = await this.s3.getObjectBuffer(this.bucket, this.key)
41 if (!buf || buf.byteLength === 0)
42 return
4343 const data = JSON.parse(buf.toString('utf-8'))
4444 this.applyState(data)
45 this.hydrated = true
4546 }
4647 catch (err) {
47 // A missing object on first run is expected (404/403). Anything else we
48 // log loudly but still start empty rather than block the server boot —
49 // and we do NOT overwrite the remote object until the next real save.
50 const msg = (err as Error).message || ''
51 if (!/\b40[34]\b/.test(msg)) {
52 console.error(`ObjectMetadataStorage: failed to load ${this.bucket}/${this.key}: ${msg}. Starting empty.`)
53 }
48 if (!isS3ObjectNotFound(err)) throw err
49 this.hydrated = true
5450 }
5551 }
5652
@@ -65,6 +61,8 @@ export class ObjectMetadataStorage extends InMemoryMetadataStorage {
6561 }
6662
6763 private async save(): Promise<void> {
64 if (!this.hydrated)
65 throw new Error(`Snapshot not hydrated: ${this.key}`)
6866 // Serialize saves so a slow upload can't be overtaken by a newer one.
6967 while (this.savePromise) await this.savePromise
7068 this.savePromise = this._doSave()
@@ -88,6 +86,7 @@ export class ObjectMetadataStorage extends InMemoryMetadataStorage {
8886
8987 /** Flush any pending save immediately (e.g. before shutdown). */
9088 async flush(): Promise<void> {
89 await this.loaded
9190 if (this.saveTimeout) {
9291 clearTimeout(this.saveTimeout)
9392 this.saveTimeout = null