fix: hydrate durable registry snapshots before serving writes

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/registry/src/build-status.test.tsmodified+5-4

Changes to packages/registry/src/build-status.test.ts

		@@ -1,3 +1,4 @@
	1	+import { S3RequestError } from './storage/aws-client'
1	2	import { describe, expect, it } from 'bun:test'
2	3	import { BuildStatusStore } from './storage/build-status'
3	4
		⋯3 linesShow the 3 lines above this hunk@@ -7,7 +8,7 @@ function mockBucket() {
7	8	const client = {
8	9	async getObjectBuffer(_bucket: string, key: string): Promise<Buffer> {
9	10	const value = objects.get(key)
10		- if (!value) throw new Error('S3 GET failed: 404 Not Found')
	11	+ if (!value) throw new S3RequestError('GET', 404, 'NoSuchKey')
11	12	return value
12	13	},
13	14	async putObject(input: { key: string, body: Buffer | string }): Promise<void> {
		⋯60 linesShow the 60 lines above this hunk@@ -74,7 +75,7 @@ describe('BuildStatusStore partial coverage', () => {
74	75	const client = {
75	76	async getObjectBuffer(_bucket: string, key: string): Promise<Buffer> {
76	77	const value = objects.get(key)
77		- if (!value) throw new Error('S3 GET failed: 404 Not Found')
	78	+ if (!value) throw new S3RequestError('GET', 404, 'NoSuchKey')
78	79	return value
79	80	},
80	81	async putObject(input: { key: string, body: Buffer | string }): Promise<void> {
		⋯54 linesShow the 54 lines above this hunk@@ -135,7 +136,7 @@ describe('BuildStatusStore partial coverage', () => {
135	136	const client = {
136	137	async getObjectBuffer(_bucket: string, key: string): Promise<Buffer> {
137	138	const value = objects.get(key)
138		- if (!value) throw new Error('S3 GET failed: 404 Not Found')
	139	+ if (!value) throw new S3RequestError('GET', 404, 'NoSuchKey')
139	140	return value
140	141	},
141	142	async putObject(input: { key: string, body: Buffer | string }): Promise<void> {
		⋯54 linesShow the 54 lines above this hunk@@ -196,7 +197,7 @@ describe('BuildStatusStore retired platforms', () => {
196	197	const client = {
197	198	async getObjectBuffer(_bucket: string, key: string): Promise<Buffer> {
198	199	const value = objects.get(key)
199		- if (!value) throw new Error('S3 GET failed: 404 Not Found')
	200	+ if (!value) throw new S3RequestError('GET', 404, 'NoSuchKey')
200	201	return value
201	202	},
202	203	async putObject(input: { key: string, body: Buffer | string }): Promise<void> {

packages/registry/src/object-analytics.test.tsmodified+2-1

Changes to packages/registry/src/object-analytics.test.ts

		⋯7 linesShow the 7 lines above this hunk@@ -8,6 +8,7 @@
8	8	* starts empty.
9	9	*/
10	10
	11	+import { S3RequestError } from './storage/aws-client'
11	12	import { describe, expect, it } from 'bun:test'
12	13	import { ObjectAnalytics } from './storage/object-analytics'
13	14
		⋯3 linesShow the 3 lines above this hunk@@ -17,7 +18,7 @@ function mockBucket() {
17	18	async getObjectBuffer(_bucket: string, key: string): Promise<Buffer> {
18	19	const v = store.get(key)
19	20	if (!v)
20		- throw new Error('S3 GET failed: 404 Not Found')
	21	+ throw new S3RequestError('GET', 404, 'NoSuchKey')
21	22	return v
22	23	},
23	24	async putObject(o: { bucket: string, key: string, body: Buffer | string }): Promise<void> {

packages/registry/src/object-metadata.test.tsmodified+2-1

Changes to packages/registry/src/object-metadata.test.ts

		⋯6 linesShow the 6 lines above this hunk@@ -7,6 +7,7 @@
7	7	* used to hold), and that a missing snapshot starts empty rather than throwing.
8	8	*/
9	9
	10	+import { S3RequestError } from './storage/aws-client'
10	11	import type { CommitPublish, PackageMetadata } from './types'
11	12	import { describe, expect, it } from 'bun:test'
12	13	import { ObjectMetadataStorage } from './storage/object-metadata'
		⋯5 linesShow the 5 lines above this hunk@@ -18,7 +19,7 @@ function mockBucket() {
18	19	async getObjectBuffer(_bucket: string, key: string): Promise<Buffer> {
19	20	const v = store.get(key)
20	21	if (!v)
21		- throw new Error('S3 GET failed: 404 Not Found')
	22	+ throw new S3RequestError('GET', 404, 'NoSuchKey')
22	23	return v
23	24	},
24	25	async putObject(o: { bucket: string, key: string, body: Buffer | string }): Promise<void> {

packages/registry/src/object-package-storage.test.tsmodified+2-1

Changes to packages/registry/src/object-package-storage.test.ts

		@@ -1,3 +1,4 @@
	1	+import { S3RequestError } from './storage/aws-client'
1	2	import { describe, expect, test } from 'bun:test'
2	3	import { ObjectPhpStorage } from './php'
3	4	import { ObjectZigStorage } from './zig'
		⋯10 linesShow the 10 lines above this hunk@@ -14,7 +15,7 @@ class MockS3 {
14	15	async getObjectBuffer(bucket: string, key: string): Promise<Buffer> {
15	16	const v = this.store.get(`${bucket}/${key}`)
16	17	if (!v)
17		- throw new Error('404 Not Found')
	18	+ throw new S3RequestError('GET', 404, 'NoSuchKey')
18	19	return v
19	20	}
20	21

packages/registry/src/server.tsmodified+10-1

Changes to packages/registry/src/server.ts

		⋯6,845 linesShow the 6,845 lines above this hunk@@ -6846,7 +6846,16 @@ if (import.meta.main) {
6846	6846	// Ensure auth storage uses the same DynamoDB table as the registry
6847	6847	const authStorage = createAuthStorage(dynamoTable, awsRegion)
6848	6848
6849		- const { start } = createServer(registry, port, analytics, undefined, undefined, undefined, authStorage)
	6849	+ const zigStorage = createZigStorage()
	6850	+ const phpStorage = createPhpStorage()
	6851	+ // Hydrate durable state before accepting any request that can mutate it.
	6852	+ // Only a confirmed missing object can initialize an empty registry.
	6853	+ await Promise.all([registry.metadata, analytics, authStorage, zigStorage, phpStorage].map(async (store) => {
	6854	+ if ('ready' in store && typeof store.ready === 'function')
	6855	+ await store.ready()
	6856	+ }))
	6857	+
	6858	+ const { start } = createServer(registry, port, analytics, zigStorage, undefined, phpStorage, authStorage)
6850	6859	start()
6851	6860
6852	6861	console.log('\nEnvironment:')

packages/registry/src/storage/object-analytics.tsmodified+8-7

Changes to packages/registry/src/storage/object-analytics.ts

		@@ -1,4 +1,5 @@
1	1	import type { S3Client } from './aws-client'
	2	+import { isS3ObjectNotFound } from './aws-client'
2	3	import { InMemoryAnalytics } from '../analytics'
3	4
4	5	/**
		⋯11 linesShow the 11 lines above this hunk@@ -16,6 +17,7 @@ import { InMemoryAnalytics } from '../analytics'
16	17	* are debounced (counters accumulate in memory between flushes).
17	18	*/
18	19	export class ObjectAnalytics extends InMemoryAnalytics {
	20	+ private hydrated = false
19	21	private s3: S3Client
20	22	private bucket: string
21	23	private key: string
		⋯17 linesShow the 17 lines above this hunk@@ -39,16 +41,12 @@ export class ObjectAnalytics extends InMemoryAnalytics {
39	41	private async load(): Promise<void> {
40	42	try {
41	43	const buf = await this.s3.getObjectBuffer(this.bucket, this.key)
42		- if (!buf || buf.byteLength === 0)
43		- return
44	44	this.applyAnalyticsState(JSON.parse(buf.toString('utf-8')))
	45	+ this.hydrated = true
45	46	}
46	47	catch (err) {
47		- const msg = (err as Error).message || ''
48		- // A missing object on first run is expected (404/403); start empty otherwise.
49		- if (!/\b40[34]\b/.test(msg)) {
50		- console.error(`ObjectAnalytics: failed to load ${this.bucket}/${this.key}: ${msg}. Starting empty.`)
51		- }
	48	+ if (!isS3ObjectNotFound(err)) throw err
	49	+ this.hydrated = true
52	50	}
53	51	}
54	52
		⋯11 linesShow the 11 lines above this hunk@@ -66,6 +64,8 @@ export class ObjectAnalytics extends InMemoryAnalytics {
66	64	}
67	65
68	66	private async save(): Promise<void> {
	67	+ if (!this.hydrated)
	68	+ throw new Error(`Snapshot not hydrated: ${this.key}`)
69	69	while (this.savePromise) await this.savePromise
70	70	this.savePromise = this.doSave()
71	71	try {
		⋯16 linesShow the 16 lines above this hunk@@ -88,6 +88,7 @@ export class ObjectAnalytics extends InMemoryAnalytics {
88	88
89	89	/** Flush any pending save immediately (e.g. before shutdown). */
90	90	async flush(): Promise<void> {
	91	+ await this.loaded
91	92	if (this.saveTimeout) {
92	93	clearTimeout(this.saveTimeout)
93	94	this.saveTimeout = null

packages/registry/src/storage/object-metadata.tsmodified+8-9

Changes to packages/registry/src/storage/object-metadata.ts

		@@ -1,4 +1,5 @@
1	1	import type { S3Client } from './aws-client'
	2	+import { isS3ObjectNotFound } from './aws-client'
2	3	import { InMemoryMetadataStorage } from './metadata'
3	4
4	5	/**
		⋯10 linesShow the 10 lines above this hunk@@ -15,6 +16,7 @@ import { InMemoryMetadataStorage } from './metadata'
15	16	* snapshot from the bucket.
16	17	*/
17	18	export class ObjectMetadataStorage extends InMemoryMetadataStorage {
	19	+ private hydrated = false
18	20	private s3: S3Client
19	21	private bucket: string
20	22	private key: string
		⋯17 linesShow the 17 lines above this hunk@@ -38,19 +40,13 @@ export class ObjectMetadataStorage extends InMemoryMetadataStorage {
38	40	private async load(): Promise<void> {
39	41	try {
40	42	const buf = await this.s3.getObjectBuffer(this.bucket, this.key)
41		- if (!buf || buf.byteLength === 0)
42		- return
43	43	const data = JSON.parse(buf.toString('utf-8'))
44	44	this.applyState(data)
	45	+ this.hydrated = true
45	46	}
46	47	catch (err) {
47		- // A missing object on first run is expected (404/403). Anything else we
48		- // log loudly but still start empty rather than block the server boot —
49		- // and we do NOT overwrite the remote object until the next real save.
50		- const msg = (err as Error).message || ''
51		- if (!/\b40[34]\b/.test(msg)) {
52		- console.error(`ObjectMetadataStorage: failed to load ${this.bucket}/${this.key}: ${msg}. Starting empty.`)
53		- }
	48	+ if (!isS3ObjectNotFound(err)) throw err
	49	+ this.hydrated = true
54	50	}
55	51	}
56	52
		⋯8 linesShow the 8 lines above this hunk@@ -65,6 +61,8 @@ export class ObjectMetadataStorage extends InMemoryMetadataStorage {
65	61	}
66	62
67	63	private async save(): Promise<void> {
	64	+ if (!this.hydrated)
	65	+ throw new Error(`Snapshot not hydrated: ${this.key}`)
68	66	// Serialize saves so a slow upload can't be overtaken by a newer one.
69	67	while (this.savePromise) await this.savePromise
70	68	this.savePromise = this._doSave()
		⋯17 linesShow the 17 lines above this hunk@@ -88,6 +86,7 @@ export class ObjectMetadataStorage extends InMemoryMetadataStorage {
88	86
89	87	/** Flush any pending save immediately (e.g. before shutdown). */
90	88	async flush(): Promise<void> {
	89	+ await this.loaded
91	90	if (this.saveTimeout) {
92	91	clearTimeout(this.saveTimeout)
93	92	this.saveTimeout = null

packages/registry/src/storage/object-snapshot.tsmodified+9-9

Changes to packages/registry/src/storage/object-snapshot.ts

		@@ -1,4 +1,5 @@
1	1	import type { S3Client } from './aws-client'
	2	+import { isS3ObjectNotFound } from './aws-client'
2	3
3	4	/**
4	5	* Reusable debounced JSON-snapshot persistence to an S3-compatible bucket.
		⋯8 linesShow the 8 lines above this hunk@@ -13,6 +14,7 @@ import type { S3Client } from './aws-client'
13	14	* the bucket under their own keys by the owning store.
14	15	*/
15	16	export class ObjectSnapshot {
	17	+ private hydrated = false
16	18	private saveTimeout: ReturnType<typeof setTimeout> | null = null
17	19	private savePromise: Promise<void> | null = null
18	20
		⋯8 linesShow the 8 lines above this hunk@@ -27,17 +29,13 @@ export class ObjectSnapshot {
27	29	async load(): Promise<unknown | null> {
28	30	try {
29	31	const buf = await this.s3.getObjectBuffer(this.bucket, this.key)
30		- if (!buf || buf.byteLength === 0)
31		- return null
32		- return JSON.parse(buf.toString('utf-8'))
	32	+ const state = JSON.parse(buf.toString('utf-8'))
	33	+ this.hydrated = true
	34	+ return state
33	35	}
34	36	catch (err) {
35		- // A missing object on first run is expected (404/403). Anything else we
36		- // surface but still start empty rather than block boot — and we do NOT
37		- // overwrite the remote object until the next real save.
38		- const msg = (err as Error).message || ''
39		- if (!/\b40[34]\b/.test(msg))
40		- console.error(`ObjectSnapshot: failed to load ${this.bucket}/${this.key}: ${msg}. Starting empty.`)
	37	+ if (!isS3ObjectNotFound(err)) throw err
	38	+ this.hydrated = true
41	39	return null
42	40	}
43	41	}
		⋯9 linesShow the 9 lines above this hunk@@ -53,6 +51,8 @@ export class ObjectSnapshot {
53	51	}
54	52
55	53	private async save(): Promise<void> {
	54	+ if (!this.hydrated)
	55	+ throw new Error(`Snapshot not hydrated: ${this.key}`)
56	56	// Serialize saves so a slow upload can't be overtaken by a newer one.
57	57	while (this.savePromise) await this.savePromise
58	58	this.savePromise = this.s3.putObject({