also looking at this
chore(deps): update dependency actions/download-artifact to v5.0.0
#178
1 file
+638
-860
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -251,11 +251,11 @@ jobs: | ||
| 251 | 251 | unlink("test.phar"); |
| 252 | 252 | } catch (Exception $e) { |
| 253 | 253 | echo "❌ Phar creation failed: " . $e->getMessage() . "\n"; |
| 254 | exit 1; | |
| 254 | exit(1); | |
| 255 | 255 | } |
| 256 | 256 | } else { |
| 257 | 257 | echo "❌ Phar extension not loaded\n"; |
| 258 | exit 1; | |
| 258 | exit(1); | |
| 259 | 259 | } |
| 260 | 260 | ?>' > test_phar_create.php |
| 261 | 261 | binaries/$BINARY_NAME/bin/php -d phar.readonly=0 test_phar_create.php |