also looking at this
chore(deps): update dependency actions/download-artifact to v5.0.0
#178
1 file
+638
-860
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -167,7 +167,31 @@ jobs: | ||
| 167 | 167 | run: | |
| 168 | 168 | # macOS: Let Launchpad handle all dependencies |
| 169 | 169 | echo "📦 macOS build will use Launchpad for all dependencies" |
| 170 | echo "🚀 No system package installation needed - Launchpad will provide everything" | |
| 170 | echo "🚀 Installing PHP dependencies via Launchpad first..." | |
| 171 | ||
| 172 | # Pre-install dependencies to ensure they're available | |
| 173 | echo "🔧 Pre-installing dependencies via Launchpad..." | |
| 174 | bun run launchpad install php --deps-only || echo "⚠️ Dependency installation had issues, continuing anyway" | |
| 175 | ||
| 176 | # Debug: Check if ICU libraries are available | |
| 177 | echo "🔍 Checking for ICU libraries..." | |
| 178 | if [ -d "$HOME/.local/unicode.org" ]; then | |
| 179 | echo "✅ ICU libraries found at: $HOME/.local/unicode.org" | |
| 180 | ls -la "$HOME/.local/unicode.org/" | |
| 181 | if [ -f "$HOME/.local/unicode.org"/*/lib/pkgconfig/icu-uc.pc ]; then | |
| 182 | echo "✅ ICU pkgconfig files found" | |
| 183 | find "$HOME/.local/unicode.org" -name "*.pc" -type f | head -5 | |
| 184 | else | |
| 185 | echo "❌ ICU pkgconfig files not found" | |
| 186 | fi | |
| 187 | else | |
| 188 | echo "❌ ICU libraries not found" | |
| 189 | fi | |
| 190 | ||
| 191 | # Debug: Check PATH and PKG_CONFIG_PATH | |
| 192 | echo "🔍 Environment check:" | |
| 193 | echo "PATH includes unicode.org: $(echo $PATH | grep -o unicode.org || echo 'NO')" | |
| 194 | echo "PKG_CONFIG_PATH: ${PKG_CONFIG_PATH:-'NOT SET'}" | |
| 171 | 195 | |
| 172 | 196 | - name: Install build dependencies (Windows) |
| 173 | 197 | if: matrix.platform == 'win32' |