also looking at this
chore(deps): update dependency actions/download-artifact to v5.0.0
#178
1 file
+638
-860
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -174,9 +174,12 @@ jobs: | ||
| 174 | 174 | - name: Install build dependencies (Windows) |
| 175 | 175 | if: matrix.platform == 'win32' |
| 176 | 176 | run: | |
| 177 | # Windows: Use pre-compiled PHP binaries instead of building from source | |
| 178 | # This is the standard approach for Windows PHP distributions | |
| 179 | echo "Windows builds will use pre-compiled PHP binaries" | |
| 177 | # Windows: Install Visual Studio Build Tools and dependencies for PHP compilation | |
| 178 | choco install visualstudio2022buildtools --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --includeRecommended --includeOptional --passive" | |
| 179 | choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System' | |
| 180 | choco install git | |
| 181 | # Install additional dependencies needed for PHP extensions | |
| 182 | echo "Windows build dependencies installed for PHP compilation" | |
| 180 | 183 | |
| 181 | 184 | - name: Build PHP |
| 182 | 185 | env: |