ReviewOS

also looking at this

pantry-pm/pantry

chore(deps): update dependency softprops/action-gh-release to v2.3.3

#159
Closed chrisbbreuer wants to merge buddy-bot/update-major-update---softprops/action-gh-release-1756037509289 into main
1 file +638 -860

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/precompile-php.ymlmodified+31-3
Changes to .github/workflows/precompile-php.yml
@@ -248,11 +248,14 @@ jobs:
248248 REQUIRED_EXTENSIONS=(
249249 "Core" "date" "hash" "json" "pcre" "Reflection" "SPL" "standard"
250250 "mbstring" "iconv" "filter" "ctype" "tokenizer" "session" "fileinfo"
251 "opcache" "phar" "dom" "xml" "xmlreader" "xmlwriter" "simplexml"
251 "phar" "dom" "xml" "xmlreader" "xmlwriter" "simplexml"
252252 "curl" "openssl" "zip" "zlib" "calendar" "ftp" "pcntl" "posix"
253253 "shmop" "sockets" "exif" "bcmath" "bz2" "gettext" "readline"
254254 )
255255
256 # Define Zend extensions that need special checking
257 ZEND_EXTENSIONS=("opcache")
258
256259 # Test each required extension
257260 echo "🧪 Testing essential extensions..."
258261 MISSING_EXTENSIONS=()
@@ -266,6 +269,17 @@ jobs:
266269 fi
267270 done
268271
272 # Test Zend extensions separately
273 for ext in "${ZEND_EXTENSIONS[@]}"; do
274 EXT_LOADED=$(binaries/$BINARY_NAME/bin/php -r "echo function_exists('opcache_get_status') ? '1' : '0';")
275 if [ "$EXT_LOADED" = "1" ]; then
276 echo "✅ $ext: LOADED"
277 else
278 echo "❌ $ext: MISSING"
279 MISSING_EXTENSIONS+=("$ext")
280 fi
281 done
282
269283 # Check if any essential extensions are missing
270284 if [ ${#MISSING_EXTENSIONS[@]} -gt 0 ]; then
271285 echo "❌ Critical extensions missing: ${MISSING_EXTENSIONS[*]}"
@@ -374,11 +388,14 @@ jobs:
374388 $REQUIRED_EXTENSIONS = @(
375389 "Core", "date", "hash", "json", "pcre", "Reflection", "SPL", "standard",
376390 "mbstring", "iconv", "filter", "ctype", "tokenizer", "session", "fileinfo",
377 "opcache", "phar", "dom", "xml", "xmlreader", "xmlwriter", "simplexml",
378 "curl", "openssl", "zip", "zlib", "calendar", "ftp", "pcntl", "posix",
391 "phar", "dom", "xml", "xmlreader", "xmlwriter", "simplexml",
392 "curl", "openssl", "zip", "zlib", "calendar", "ftp",
379393 "shmop", "sockets", "exif", "bcmath", "bz2", "gettext", "readline"
380394 )
381395
396 # Define Zend extensions that need special checking
397 $ZEND_EXTENSIONS = @("opcache")
398
382399 # Test each required extension
383400 Write-Host "🧪 Testing essential extensions..."
384401 $MISSING_EXTENSIONS = @()
@@ -392,6 +409,17 @@ jobs:
392409 }
393410 }
394411
412 # Test Zend extensions separately
413 foreach ($ext in $ZEND_EXTENSIONS) {
414 $extLoaded = & $PHP -r "echo function_exists('opcache_get_status') ? '1' : '0';"
415 if ($extLoaded -eq "1") {
416 Write-Host "✅ $ext`: LOADED"
417 } else {
418 Write-Host "❌ $ext`: MISSING"
419 $MISSING_EXTENSIONS += $ext
420 }
421 }
422
395423 # Check if any essential extensions are missing
396424 if ($MISSING_EXTENSIONS.Count -gt 0) {
397425 Write-Host "❌ Critical extensions missing: $($MISSING_EXTENSIONS -join ', ')"