ReviewOS

also looking at this

meemalabs/meema-client-php

Apply fixes from StyleCI

#79
Merged glennmichael123 wants to merge analysis-NAoPVr into media-uuid
3 files +7 -6

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

src/Exceptions/InvalidFormatException.phpmodifiedformatting only+1-1
Changes to src/Exceptions/InvalidFormatException.php
@@ -16,6 +16,6 @@ class InvalidFormatException extends Exception
1616 $customMessage = $message ? " {$message}" : ' ID is not a valid integer';
1717
1818 parent::__construct('Error on line '.$this->getLine().' in '.$this->getFile()
19 . $customMessage);
19 .$customMessage);
2020 }
2121}
src/Traits/DetectsFeature.phpmodifiedformatting only+1-1
Changes to src/Traits/DetectsFeature.php
@@ -11,7 +11,7 @@ trait DetectsFeature
1111 * Detect if the function called doesn't exist or a missing feature.
1212 *
1313 * @return void
14 *
14 *
1515 * @throws BadMethodCallException
1616 * @throws FeatureNotImplementedException
1717 */
src/Traits/ValidsUuid.phpmodified+5-4
Changes to src/Traits/ValidsUuid.php
@@ -5,14 +5,15 @@ namespace Meema\MeemaClient\Traits;
55trait ValidsUuid
66{
77 /**
8 * Check if a given string is a valid UUID
8 * Check if a given string is a valid UUID.
99 *
1010 * @param string $uuid
1111 *
12 * @return boolean
12 * @return bool
1313 */
14 public function isValidUuid( $uuid ) {
15 if (!is_string($uuid) || (preg_match('/^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/', $uuid) !== 1)) {
14 public function isValidUuid($uuid)
15 {
16 if (! is_string($uuid) || (preg_match('/^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/', $uuid) !== 1)) {
1617 return false;
1718 }
1819