ReviewOS

also looking at this

meemalabs/meema-client-php

Remove "data" in array response

#47
Merged glennmichael123 wants to merge remove-data-array into main
5 files +40 -34
tests/MeemaFolderTest.phpmodified+10-10
Changes to tests/MeemaFolderTest.php
@@ -17,12 +17,12 @@ it('can fetch all folders', function () {
1717it('can search a folder', function () {
1818 $folder = $this->client->folders()->find(1)->toArray();
1919
20 $query = $folder['data']['name'];
20 $query = $folder['name'];
2121
2222 $folders = $this->client->folders()->search($query);
2323
2424 $this->assertTrue(is_array($folders));
25 $this->assertTrue(str_contains($folders['data'][0]['name'], $query));
25 $this->assertTrue(str_contains($folders[0]['name'], $query));
2626});
2727
2828it('can fetch specific group of folders', function () {
@@ -31,7 +31,7 @@ it('can fetch specific group of folders', function () {
3131 $folders = $this->client->folders()->get($ids);
3232
3333 $this->assertTrue(is_array($folders));
34 $this->assertTrue(count($folders['data']) === count($ids));
34 $this->assertTrue(count($folders) === count($ids));
3535});
3636
3737it('can find a single folder', function () {
@@ -40,7 +40,7 @@ it('can find a single folder', function () {
4040 $folders = $this->client->folders()->find($id)->toArray();
4141
4242 $this->assertTrue(is_array($folders));
43 $this->assertTrue(count($folders) === 1);
43 $this->assertTrue(array_key_exists('id', $folders));
4444});
4545
4646it('can create a folder', function () {
@@ -49,7 +49,7 @@ it('can create a folder', function () {
4949 $media = $this->client->folders()->create($name);
5050
5151 $this->assertTrue(is_array($media));
52 $this->assertTrue($media['data']['name'] === $name);
52 $this->assertTrue($media['name'] === $name);
5353});
5454
5555it('can update a folder', function () {
@@ -58,21 +58,21 @@ it('can update a folder', function () {
5858 $folders = $this->client->folders()->update(1, $name);
5959
6060 $this->assertTrue(is_array($folders));
61 $this->assertTrue($folders['data']['name'] === $name);
61 $this->assertTrue($folders['name'] === $name);
6262});
6363
6464it('can archive a folder', function () {
6565 $folders = $this->client->folders()->archive(1);
6666
6767 $this->assertTrue(is_array($folders));
68 $this->assertTrue((bool) $folders['data']['is_archived']);
68 $this->assertTrue((bool) $folders['is_archived']);
6969});
7070
7171it('can unarchive a folder', function () {
7272 $folders = $this->client->folders()->unarchive(1);
7373
7474 $this->assertTrue(is_array($folders));
75 $this->assertFalse((bool) $folders['data']['is_archived']);
75 $this->assertFalse((bool) $folders['is_archived']);
7676});
7777
7878it('can duplicate a folder', function () {
@@ -81,13 +81,13 @@ it('can duplicate a folder', function () {
8181 $duplicated = $folders->duplicate();
8282
8383 $this->assertTrue(is_array($duplicated));
84 $this->assertTrue($duplicated['data']['name'] === $folders->toArray()['data']['name']);
84 $this->assertTrue($duplicated['name'] === $folders->toArray()['name']);
8585});
8686
8787it('can delete a folder', function () {
8888 $folders = $this->client->folders()->get();
8989
90 $folders = array_reverse($folders['data']);
90 $folders = array_reverse($folders);
9191 $response = $this->client->folders()->delete($folders[0]['id']);
9292
9393 $this->assertTrue(is_null($response));