ReviewOS

also looking at this

meemalabs/laravel-text-to-speech

Support laravel 9

#32
Merged luigel wants to merge support-laravel-9 into main
17 files +83 -61

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/run-tests.ymlmodified+4-2
Changes to .github/workflows/run-tests.yml
@@ -10,10 +10,12 @@ jobs:
1010 strategy:
1111 fail-fast: false
1212 matrix:
13 php: [7.3, 7.4, 8.0]
14 laravel: [6.*, 7.*, 8.*]
13 php: [7.3, 7.4, 8.0, 8.1]
14 laravel: [6.*, 7.*, 8.*, 9.*]
1515 dependency-version: [prefer-lowest, prefer-stable]
1616 include:
17 - laravel: 9.*
18 testbench: 7.*
1719 - laravel: 8.*
1820 testbench: 6.*
1921 - laravel: 7.*
composer.jsonmodified+2-2
Changes to composer.json
@@ -28,11 +28,11 @@
2828 "php": "^7.3|^7.4|^8.0",
2929 "aws/aws-sdk-php": "^3.178",
3030 "guzzlehttp/guzzle": "^6.0|^7.0",
31 "illuminate/support": "5.*|^6.0|^7.0|^8.0",
31 "illuminate/support": "5.*|^6.0|^7.0|^8.0|^9.0",
3232 "ext-json": "*"
3333 },
3434 "require-dev": {
35 "orchestra/testbench": "^4.0|^5.0|^6.0",
35 "orchestra/testbench": "^4.0|^5.0|^6.0|^7.0",
3636 "phpunit/phpunit": "^5.0|^6.0|^8.0|^9.3"
3737 },
3838 "autoload": {
src/Contracts/Converter.phpmodified+2-1
Changes to src/Contracts/Converter.php
@@ -8,7 +8,8 @@ interface Converter
88 * Converts text to speech.
99 *
1010 * @param string $text
11 * @param array $options
11 * @param array|null $options
12 *
1213 * @return mixed
1314 */
1415 public function convert(string $text, array $options = null);
src/Converters/NullConverter.phpmodified+3-2
Changes to src/Converters/NullConverter.php
@@ -16,8 +16,9 @@ class NullConverter implements Converter
1616 * Converts the text to speech.
1717 *
1818 * @param mixed $data
19 * @param array $options
20 * @return void
19 * @param array|null $options
20 *
21 * @return string
2122 */
2223 public function convert($data, array $options = null)
2324 {
src/Converters/PollyConverter.phpmodified+5-3
Changes to src/Converters/PollyConverter.php
@@ -47,7 +47,8 @@ class PollyConverter implements Converter
4747 * Converts the text to speech.
4848 *
4949 * @param string $data
50 * @param array $options
50 * @param array|null $options
51 *
5152 * @return string|array
5253 */
5354 public function convert(string $data, array $options = null)
@@ -82,7 +83,8 @@ class PollyConverter implements Converter
8283 * Request to Amazon Polly to synthesize speech.
8384 *
8485 * @param string|array $text
85 * @param array $options
86 * @param array|null $options
87 *
8688 * @return array|\Aws\Result
8789 */
8890 protected function synthesizeSpeech($text, array $options = null)
@@ -111,7 +113,7 @@ class PollyConverter implements Converter
111113 'Text' => $textItem,
112114 ]));
113115
114 array_push($results, $result);
116 $results[] = $result;
115117 }
116118
117119 return $results;
src/Traits/Sourceable.phpmodified+2-0
Changes to src/Traits/Sourceable.php
@@ -28,7 +28,9 @@ trait Sourceable
2828
2929 /**
3030 * Get text from source.
31 *
3132 * @param string $data
33 *
3234 * @return string
3335 */
3436 protected function getTextFromSource(string $data): string
src/Traits/Storable.phpmodified+1-1
Changes to src/Traits/Storable.php
@@ -63,7 +63,7 @@ trait Storable
6363
6464 $storage = Storage::disk($this->disk ?: config('tts.disk'));
6565
66 $storage->put($this->path, $resultContent);
66 $storage->put($this->path, $resultContent ?? '');
6767
6868 return $this->path;
6969 }