also looking at this
meemalabs/laravel-text-to-speech
Support laravel 9
#32
17 files
+83
-61
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -10,10 +10,12 @@ jobs: | ||
| 10 | 10 | strategy: |
| 11 | 11 | fail-fast: false |
| 12 | 12 | matrix: |
| 13 | php: [7.3, 7.4, 8.0] | |
| 14 | laravel: [6.*, 7.*, 8.*] | |
| 13 | php: [7.3, 7.4, 8.0, 8.1] | |
| 14 | laravel: [6.*, 7.*, 8.*, 9.*] | |
| 15 | 15 | dependency-version: [prefer-lowest, prefer-stable] |
| 16 | 16 | include: |
| 17 | - laravel: 9.* | |
| 18 | testbench: 7.* | |
| 17 | 19 | - laravel: 8.* |
| 18 | 20 | testbench: 6.* |
| 19 | 21 | - laravel: 7.* |
| @@ -28,11 +28,11 @@ | ||
| 28 | 28 | "php": "^7.3|^7.4|^8.0", |
| 29 | 29 | "aws/aws-sdk-php": "^3.178", |
| 30 | 30 | "guzzlehttp/guzzle": "^6.0|^7.0", |
| 31 | "illuminate/support": "5.*|^6.0|^7.0|^8.0", | |
| 31 | "illuminate/support": "5.*|^6.0|^7.0|^8.0|^9.0", | |
| 32 | 32 | "ext-json": "*" |
| 33 | 33 | }, |
| 34 | 34 | "require-dev": { |
| 35 | "orchestra/testbench": "^4.0|^5.0|^6.0", | |
| 35 | "orchestra/testbench": "^4.0|^5.0|^6.0|^7.0", | |
| 36 | 36 | "phpunit/phpunit": "^5.0|^6.0|^8.0|^9.3" |
| 37 | 37 | }, |
| 38 | 38 | "autoload": { |
| @@ -16,8 +16,9 @@ class NullConverter implements Converter | ||
| 16 | 16 | * Converts the text to speech. |
| 17 | 17 | * |
| 18 | 18 | * @param mixed $data |
| 19 | * @param array $options | |
| 20 | * @return void | |
| 19 | * @param array|null $options | |
| 20 | * | |
| 21 | * @return string | |
| 21 | 22 | */ |
| 22 | 23 | public function convert($data, array $options = null) |
| 23 | 24 | { |
| @@ -47,7 +47,8 @@ class PollyConverter implements Converter | ||
| 47 | 47 | * Converts the text to speech. |
| 48 | 48 | * |
| 49 | 49 | * @param string $data |
| 50 | * @param array $options | |
| 50 | * @param array|null $options | |
| 51 | * | |
| 51 | 52 | * @return string|array |
| 52 | 53 | */ |
| 53 | 54 | public function convert(string $data, array $options = null) |
| @@ -82,7 +83,8 @@ class PollyConverter implements Converter | ||
| 82 | 83 | * Request to Amazon Polly to synthesize speech. |
| 83 | 84 | * |
| 84 | 85 | * @param string|array $text |
| 85 | * @param array $options | |
| 86 | * @param array|null $options | |
| 87 | * | |
| 86 | 88 | * @return array|\Aws\Result |
| 87 | 89 | */ |
| 88 | 90 | protected function synthesizeSpeech($text, array $options = null) |
| @@ -111,7 +113,7 @@ class PollyConverter implements Converter | ||
| 111 | 113 | 'Text' => $textItem, |
| 112 | 114 | ])); |
| 113 | 115 | |
| 114 | array_push($results, $result); | |
| 116 | $results[] = $result; | |
| 115 | 117 | } |
| 116 | 118 | |
| 117 | 119 | return $results; |