also looking at this
meemalabs/laravel-text-to-speech
Apply fixes from StyleCI
#1
4 files
+6
-6
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -4,10 +4,10 @@ namespace Cion\TextToSpeech\Converters; | ||
| 4 | 4 | |
| 5 | 5 | use Aws\Credentials\Credentials; |
| 6 | 6 | use Aws\Polly\PollyClient; |
| 7 | use Illuminate\Support\Arr; | |
| 8 | 7 | use Cion\TextToSpeech\Contracts\Converter; |
| 9 | 8 | use Cion\TextToSpeech\Traits\Sourceable; |
| 10 | 9 | use Cion\TextToSpeech\Traits\Storable; |
| 10 | use Illuminate\Support\Arr; | |
| 11 | 11 | |
| 12 | 12 | class PollyConverter implements Converter |
| 13 | 13 | { |
| @@ -2,9 +2,9 @@ | ||
| 2 | 2 | |
| 3 | 3 | namespace Cion\TextToSpeech\Providers; |
| 4 | 4 | |
| 5 | use Illuminate\Support\ServiceProvider; | |
| 6 | 5 | use Cion\TextToSpeech\Facades\TextToSpeech; |
| 7 | 6 | use Cion\TextToSpeech\TextToSpeechManager; |
| 7 | use Illuminate\Support\ServiceProvider; | |
| 8 | 8 | |
| 9 | 9 | class TextToSpeechServiceProvider extends ServiceProvider |
| 10 | 10 | { |
| @@ -3,10 +3,10 @@ | ||
| 3 | 3 | namespace Cion\TextToSpeech; |
| 4 | 4 | |
| 5 | 5 | use Aws\Polly\PollyClient; |
| 6 | use Exception; | |
| 7 | use Illuminate\Support\Manager; | |
| 8 | 6 | use Cion\TextToSpeech\Converters\NullConverter; |
| 9 | 7 | use Cion\TextToSpeech\Converters\PollyConverter; |
| 8 | use Exception; | |
| 9 | use Illuminate\Support\Manager; | |
| 10 | 10 | |
| 11 | 11 | class TextToSpeechManager extends Manager |
| 12 | 12 | { |
| @@ -72,7 +72,7 @@ trait Storable formatting only | ||
| 72 | 72 | { |
| 73 | 73 | $filename = $this->path ?: 'TTS/'.now()->timestamp; |
| 74 | 74 | |
| 75 | if (!$this->hasExtension($filename)) { | |
| 75 | if (! $this->hasExtension($filename)) { | |
| 76 | 76 | $filename .= '.'.$this->getExtension(); |
| 77 | 77 | } |
| 78 | 78 | |
| @@ -83,7 +83,7 @@ trait Storable | ||
| 83 | 83 | * Determine if filename includes file extension. |
| 84 | 84 | * |
| 85 | 85 | * @param string $filename |
| 86 | * @return boolean | |
| 86 | * @return bool | |
| 87 | 87 | */ |
| 88 | 88 | protected function hasExtension($filename) |
| 89 | 89 | { |