ReviewOS

also looking at this

meemalabs/laravel-meema

Implement Tests

#8
Closed glennmichael123 wants to merge implemen-test into main
6 files +16 -18

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/run-tests.ymlmodified+2-2
Changes to .github/workflows/run-tests.yml
@@ -41,10 +41,10 @@ jobs:
4141
4242 - name: Install dependencies
4343 run: |
44 composer require "laravel/framework:$" "orchestra/testbench:$" --no-interaction --no-update
45 composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
44 composer install
4645
4746 - name: Execute tests
4847 run: vendor/bin/pest
4948 env:
5049 MEEMA_API_KEY: ${{ secrets.MEEMA_API_KEY }}
50 BASE_URL_TEST: ${{ secrets.BASE_URL_TEST }}
src/Providers/MeemaServiceProvider.phpmodified+3-1
Changes to src/Providers/MeemaServiceProvider.php
@@ -53,7 +53,9 @@ class MeemaServiceProvider extends ServiceProvider
5353 protected function registerMeemaClient()
5454 {
5555 $this->app->singleton('meema', function ($app) {
56 return new Client(config('meema.api_key'));
56 $config = ['base_url' => config('meema.meema_test_url')];
57
58 return new Client(config('meema.api_key'), $config);
5759 });
5860 }
5961}
tests/LaravelMeemaTestCase.phpmodified+1-0
Changes to tests/LaravelMeemaTestCase.php
@@ -27,5 +27,6 @@ class LaravelMeemaTestCase extends TestCase
2727 {
2828 // let's make sure these config values are set
2929 Config::set('meema.api_key', env('MEEMA_API_KEY'));
30 Config::set('meema.meema_test_url', env('BASE_URL_TEST'));
3031 }
3132}