ReviewOS

also looking at this

meemalabs/laravel-meema

Fix test cases

#15
Merged glennmichael123 wants to merge fix-test-cases into main
4 files +63 -25

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

tests/FolderTest.phpmodified+22-8
Changes to tests/FolderTest.php
@@ -19,7 +19,9 @@ it('can fetch all folders', function () {
1919});
2020
2121it('can search a folder', function () {
22 $folder = Folder::find(1)->toArray();
22 $folders = Folder::get();
23
24 $folder = Folder::find($folders[0]['id'])->toArray();
2325
2426 $query = $folder['name'];
2527
@@ -30,7 +32,9 @@ it('can search a folder', function () {
3032});
3133
3234it('can fetch specific group of folders', function () {
33 $ids = [1, 2, 3];
35 $folders = Folder::get();
36
37 $ids = [$folders[0]['id'], $folders[1]['id'], $folders[2]['id']];
3438
3539 $folders = Folder::get($ids);
3640
@@ -39,9 +43,11 @@ it('can fetch specific group of folders', function () {
3943});
4044
4145it('can find a single folder', function () {
42 $id = 1;
46 $folders = Folder::get();
47
48 $id = $folders[0]['id'];
4349
44 $folders = Folder::find(1)->toArray();
50 $folders = Folder::find($id)->toArray();
4551
4652 $this->assertTrue(is_array($folders));
4753 $this->assertTrue(array_key_exists('id', $folders));
@@ -57,30 +63,38 @@ it('can create a folder', function () {
5763});
5864
5965it('can update a folder', function () {
66 $folders = Folder::get();
67
6068 $name = 'test folder';
6169
62 $folders = Folder::update(1, $name);
70 $folders = Folder::update($folders[0]['id'], $name);
6371
6472 $this->assertTrue(is_array($folders));
6573 $this->assertTrue($folders['name'] === $name);
6674});
6775
6876it('can archive a folder', function () {
69 $folders = Folder::archive(1);
77 $folders = Folder::get();
78
79 $folders = Folder::archive($folders[0]['id']);
7080
7181 $this->assertTrue(is_array($folders));
7282 $this->assertTrue((bool) $folders['is_archived']);
7383});
7484
7585it('can unarchive a folder', function () {
76 $folders = Folder::unarchive(1);
86 $folders = Folder::get();
87
88 $folders = Folder::unarchive($folders[0]['id']);
7789
7890 $this->assertTrue(is_array($folders));
7991 $this->assertFalse((bool) $folders['is_archived']);
8092});
8193
8294it('can duplicate a folder', function () {
83 $folders = Folder::find(1);
95 $folders = Folder::get();
96
97 $folders = Folder::find($folders[0]['id']);
8498
8599 $duplicated = $folders->duplicate();
86100
tests/LaravelMeemaTestCase.phpmodified+2-2
Changes to tests/LaravelMeemaTestCase.php
@@ -26,7 +26,7 @@ class LaravelMeemaTestCase extends TestCase
2626 public function initializeSettings()
2727 {
2828 // let's make sure these config values are set
29 Config::set('meema.api_key', env('MEEMA_API_KEY'));
30 Config::set('meema.meema_test_url', env('BASE_URL_TEST'));
29 Config::set('meema.api_secret', env('MEEMA_API_KEY'));
30 Config::set('meema.base_url', env('BASE_URL_TEST'));
3131 }
3232}
tests/MediaTest.phpmodified+33-13
Changes to tests/MediaTest.php
@@ -21,7 +21,9 @@ it('can be fetch all media', function () {
2121});
2222
2323it('can search a media', function () {
24 $media = Media::find(1)->toArray();
24 $allMedia = Media::get();
25
26 $media = Media::find($allMedia[0]['id'])->toArray();
2527 $query = $media['name'];
2628
2729 $media = Media::search($query);
@@ -41,8 +43,10 @@ it('can be fetch all media for a tag', function () {
4143});
4244
4345it('can be fetch all media for a folder', function () {
46 $folders = Folder::get();
47
4448 // 8 is the tag id for images
45 $folder = Folder::find(1);
49 $folder = Folder::find($folders[0]['id']);
4650
4751 $media = $folder->media()->get();
4852
@@ -51,7 +55,9 @@ it('can be fetch all media for a folder', function () {
5155});
5256
5357it('can be fetch specific group of media', function () {
54 $ids = [1, 2, 3];
58 $allMedia = Media::get();
59
60 $ids = [$allMedia[0]['id'], $allMedia[1]['id'], $allMedia[2]['id']];
5561
5662 $media = Media::get($ids);
5763
@@ -60,55 +66,69 @@ it('can be fetch specific group of media', function () {
6066});
6167
6268it('can find a single media', function () {
63 $id = 1;
69 $allMedia = Media::get();
6470
65 $media = Media::find(1)->toArray();
71 $id = $allMedia[0]['id'];
72
73 $media = Media::find($id)->toArray();
6674
6775 $this->assertTrue(is_array($media));
6876 $this->assertTrue(array_key_exists('id', $media));
6977});
7078
7179it('can update a media', function () {
80 $allMedia = Media::get();
81
7282 $name = 'test media';
7383
74 $media = Media::update(1, $name);
84 $media = Media::update($allMedia[0]['id'], $name);
7585
7686 $this->assertTrue(is_array($media));
7787 $this->assertTrue($media['name'] === $name);
7888});
7989
8090it('can archive a media', function () {
81 $media = Media::archive(1);
91 $allMedia = Media::get();
92
93 $media = Media::archive($allMedia[0]['id']);
8294
8395 $this->assertTrue(is_array($media));
8496 $this->assertTrue((bool) $media['is_archived']);
8597});
8698
8799it('can unarchive a media', function () {
88 $media = Media::unarchive(1);
100 $allMedia = Media::get();
101
102 $media = Media::unarchive($allMedia[0]['id']);
89103
90104 $this->assertTrue(is_array($media));
91105 $this->assertFalse((bool) $media['is_archived']);
92106});
93107
94108it('can make a media private', function () {
95 $media = Media::makePrivate(1);
109 $allMedia = Media::get();
110
111 $media = Media::makePrivate($allMedia[0]['id']);
96112
97113 $this->assertTrue(is_array($media));
98114 $this->assertFalse((bool) $media['is_public']);
99115});
100116
101117it('can make a media public', function () {
102 $media = Media::makePublic(1);
118 $allMedia = Media::get();
119
120 $media = Media::makePublic($allMedia[0]['id']);
103121
104122 $this->assertTrue(is_array($media));
105123 $this->assertTrue((bool) $media['is_public']);
106124});
107125
108126it('can duplicate a media', function () {
109 $media = Media::find(1);
127 $allMedia = Media::get();
128
129 $media = Media::find($allMedia[0]['id']);
110130
111 $duplicated = Media::duplicate(1);
131 $duplicated = Media::duplicate($allMedia[0]['id']);
112132
113133 $this->assertTrue(is_array($duplicated));
114134 $this->assertTrue($duplicated['name'] === $media->toArray()['name']);
@@ -118,7 +138,7 @@ it('can delete a media', function () {
118138 $media = Media::get()->toArray();
119139
120140 $media = array_reverse($media);
121 $response = Media::delete((int) $media[0]['media_id']);
141 $response = Media::delete($media[0]['id']);
122142
123143 $this->assertTrue(is_null($response));
124144});
tests/TagTest.phpmodified+6-2
Changes to tests/TagTest.php
@@ -48,7 +48,9 @@ it('can update a tag', function () {
4848});
4949
5050it('can fetch all media tags', function () {
51 $media = Media::find(1);
51 $allMedia = Media::get();
52
53 $media = Media::find($allMedia[0]['id']);
5254 $tags = $media->tags()->get();
5355
5456 $this->assertTrue($tags instanceof Collection);
@@ -56,7 +58,9 @@ it('can fetch all media tags', function () {
5658});
5759
5860it('can fetch all folder tags', function () {
59 $folder = Folder::find(1);
61 $folders = Folder::get();
62
63 $folder = Folder::find($folders[0]['id']);
6064
6165 $tags = $folder->tags()->get();
6266