also looking at this
meemalabs/laravel-media-converter
fix: restore media_id
#20
1 file
+16
-6
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -35,7 +35,7 @@ class CreateVideoConversion implements ShouldQueue | ||
| 35 | 35 | * @param array $tags |
| 36 | 36 | * @param int $mediaId |
| 37 | 37 | */ |
| 38 | public function __construct($jobSettings, $tags, $mediaId = null) | |
| 38 | public function __construct($jobSettings, $tags = [], $mediaId = null) | |
| 39 | 39 | { |
| 40 | 40 | $this->jobSettings = $jobSettings; |
| 41 | 41 | $this->tags = $tags; |