also looking at this
meemalabs/laravel-media-converter
Apply fixes from StyleCI
#1
4 files
+11
-11
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -29,7 +29,7 @@ class MediaConverter implements Converter | ||
| 29 | 29 | 'version' => $config['version'], |
| 30 | 30 | 'region' => $config['region'], |
| 31 | 31 | 'credentials' => new Credentials($config['credentials']['key'], $config['credentials']['secret']), |
| 32 | 'endpoint' => $result['Endpoints'][0]['Url'] | |
| 32 | 'endpoint' => $result['Endpoints'][0]['Url'], | |
| 33 | 33 | ]); |
| 34 | 34 | } |
| 35 | 35 | |
| @@ -66,14 +66,14 @@ class MediaConverter implements Converter | ||
| 66 | 66 | public function createJob(array $settings, $priority = 0) |
| 67 | 67 | { |
| 68 | 68 | return $this->client->createJob([ |
| 69 | "Role" => config('media-convert.iam_arn'), | |
| 70 | "Settings" => $settings, // JobSettings structure | |
| 71 | "Queue" => config('media-convert.queue_arn'), | |
| 72 | "UserMetadata" => [ | |
| 73 | "Customer" => "Amazon", | |
| 69 | 'Role' => config('media-convert.iam_arn'), | |
| 70 | 'Settings' => $settings, // JobSettings structure | |
| 71 | 'Queue' => config('media-convert.queue_arn'), | |
| 72 | 'UserMetadata' => [ | |
| 73 | 'Customer' => 'Amazon', | |
| 74 | 74 | ], |
| 75 | "StatusUpdateInterval" => "SECONDS_60", | |
| 76 | "Priority" => $priority | |
| 75 | 'StatusUpdateInterval' => 'SECONDS_60', | |
| 76 | 'Priority' => $priority, | |
| 77 | 77 | ]); |
| 78 | 78 | } |
| 79 | 79 | |
| @@ -4,9 +4,9 @@ namespace Meema\MediaConvert; | ||
| 4 | 4 | |
| 5 | 5 | use Aws\Credentials\Credentials; |
| 6 | 6 | use Aws\MediaConvert\MediaConvertClient; |
| 7 | use Meema\MediaConvert\Converters\MediaConverter; | |
| 8 | 7 | use Exception; |
| 9 | 8 | use Illuminate\Support\Manager; |
| 9 | use Meema\MediaConvert\Converters\MediaConverter; | |
| 10 | 10 | |
| 11 | 11 | class MediaConvertManager extends Manager |
| 12 | 12 | { |
| @@ -2,9 +2,9 @@ | ||
| 2 | 2 | |
| 3 | 3 | namespace Meema\MediaConvert\Providers; |
| 4 | 4 | |
| 5 | use Illuminate\Support\ServiceProvider; | |
| 5 | 6 | use Meema\MediaConvert\Facades\MediaConvert; |
| 6 | 7 | use Meema\MediaConvert\MediaConvertManager; |
| 7 | use Illuminate\Support\ServiceProvider; | |
| 8 | 8 | |
| 9 | 9 | class MediaConvertServiceProvider extends ServiceProvider |
| 10 | 10 | { |
| @@ -2,9 +2,9 @@ | ||
| 2 | 2 | |
| 3 | 3 | namespace Meema\MediaConvert\Sources; |
| 4 | 4 | |
| 5 | use Meema\MediaConvert\Contracts\Source as SourceContract; | |
| 6 | 5 | use DOMDocument; |
| 7 | 6 | use DOMNodeList; |
| 7 | use Meema\MediaConvert\Contracts\Source as SourceContract; | |
| 8 | 8 | use RecursiveIteratorIterator; |
| 9 | 9 | |
| 10 | 10 | class WebsiteSource implements SourceContract |