also looking at this
meemalabs/laravel-media-converter
feat: add support for tagging
#17
4 files
+20
-5
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -41,7 +41,7 @@ class CreateVideoConversion implements ShouldQueue formatting only | ||
| 41 | 41 | { |
| 42 | 42 | $metaData = []; |
| 43 | 43 | $tags = []; |
| 44 | ||
| 44 | ||
| 45 | 45 | if ($this->mediaId) { |
| 46 | 46 | $metaData = ['model_id' => $this->mediaId]; |
| 47 | 47 | } |
| @@ -50,8 +50,6 @@ class CreateVideoConversion implements ShouldQueue | ||
| 50 | 50 | $tags = ['team_id' => $this->teamId]; |
| 51 | 51 | } |
| 52 | 52 | |
| 53 | ||
| 54 | ||
| 55 | 53 | MediaConvert::createJob($this->jobSettings, $metaData, $tags); |
| 56 | 54 | } |
| 57 | 55 | } |