ReviewOS

also looking at this

meemalabs/laravel-media-converter

feat: add support for tagging

#17
Merged glennmichael123 wants to merge add-tags into main
4 files +20 -5

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

src/Contracts/Converter.phpmodified+1-1
Changes to src/Contracts/Converter.php
@@ -58,7 +58,7 @@ interface Converter
5858 * @param int $priority
5959 * @return \Aws\Result
6060 */
61 public function createJob(array $settings, array $metaData, int $priority);
61 public function createJob(array $settings, array $metaData, array $tags, int $priority);
6262
6363 /**
6464 * Gets the job.
src/Converters/MediaConvert.phpmodified+2-1
Changes to src/Converters/MediaConvert.php
@@ -146,13 +146,14 @@ class MediaConvert implements Converter
146146 * @param int $priority
147147 * @return \Aws\Result
148148 */
149 public function createJob(array $settings, array $metaData = [], int $priority = 0)
149 public function createJob(array $settings, array $metaData = [], array $tags = [], int $priority = 0)
150150 {
151151 return $this->client->createJob([
152152 'Role' => config('media-converter.iam_arn'),
153153 'Settings' => $settings,
154154 'Queue' => config('media-converter.queue_arn'),
155155 'UserMetadata' => $metaData,
156 'Tags' => $tags,
156157 'StatusUpdateInterval' => $this->getStatusUpdateInterval(),
157158 'Priority' => $priority,
158159 ]);
src/Jobs/CreateVideoConversion.phpmodified+9-2
Changes to src/Jobs/CreateVideoConversion.php
@@ -40,11 +40,18 @@ class CreateVideoConversion implements ShouldQueue
4040 public function handle()
4141 {
4242 $metaData = [];
43
43 $tags = [];
44
4445 if ($this->mediaId) {
4546 $metaData = ['model_id' => $this->mediaId];
4647 }
4748
48 MediaConvert::createJob($this->jobSettings, $metaData);
49 if ($this->teamId) {
50 $tags = ['team_id' => $this->teamId];
51 }
52
53
54
55 MediaConvert::createJob($this->jobSettings, $metaData, $tags);
4956 }
5057}