ReviewOS

also looking at this

meemalabs/laravel-media-converter

[1.0] Introducing the "Simple Usage" API

#14
Merged chris wants to merge v1.0 into main
10 files +406 -200

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/run-tests.ymlmodified+2-4
Changes to .github/workflows/run-tests.yml
@@ -12,7 +12,8 @@ jobs:
1212 matrix:
1313 php: [7.4, 8.0]
1414 laravel: [7.*, 8.*]
15 dependency-version: [prefer-lowest, prefer-stable]
15 dependency-version: [prefer-stable]
16# dependency-version: [prefer-lowest, prefer-stable]
1617 include:
1718 - laravel: 8.*
1819 testbench: 6.*
@@ -42,9 +43,6 @@ jobs:
4243 composer require "laravel/framework:$" "orchestra/testbench:$" --no-interaction --no-update
4344 composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
4445
45 - name: Create .env file
46 run: touch .env # this can be an empty file, just need the test to pass. GitHub Actions uses GitHub Secrets
47
4846 - name: Execute tests
4947 run: vendor/bin/pest
5048 env:
tests/MediaConverterTestCase.phpmodified+4-0
Changes to tests/MediaConverterTestCase.php
@@ -17,6 +17,10 @@ class MediaConverterTestCase extends TestCase
1717
1818 public function initializeDotEnv()
1919 {
20 if (! file_exists(__DIR__.'/../.env')) {
21 return;
22 }
23
2024 $dotenv = \Dotenv\Dotenv::createImmutable(dirname(__DIR__));
2125 $dotenv->load();
2226 }