also looking at this
meemalabs/laravel-media-converter
[1.0] Introducing the "Simple Usage" API
#14
10 files
+406
-200
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -12,7 +12,8 @@ jobs: | ||
| 12 | 12 | matrix: |
| 13 | 13 | php: [7.4, 8.0] |
| 14 | 14 | laravel: [7.*, 8.*] |
| 15 | dependency-version: [prefer-lowest, prefer-stable] | |
| 15 | dependency-version: [prefer-stable] | |
| 16 | # dependency-version: [prefer-lowest, prefer-stable] | |
| 16 | 17 | include: |
| 17 | 18 | - laravel: 8.* |
| 18 | 19 | testbench: 6.* |
| @@ -42,9 +43,6 @@ jobs: | ||
| 42 | 43 | composer require "laravel/framework:$" "orchestra/testbench:$" --no-interaction --no-update |
| 43 | 44 | composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest |
| 44 | 45 | |
| 45 | - name: Create .env file | |
| 46 | run: touch .env # this can be an empty file, just need the test to pass. GitHub Actions uses GitHub Secrets | |
| 47 | ||
| 48 | 46 | - name: Execute tests |
| 49 | 47 | run: vendor/bin/pest |
| 50 | 48 | env: |
| @@ -17,6 +17,10 @@ class MediaConverterTestCase extends TestCase | ||
| 17 | 17 | |
| 18 | 18 | public function initializeDotEnv() |
| 19 | 19 | { |
| 20 | if (! file_exists(__DIR__.'/../.env')) { | |
| 21 | return; | |
| 22 | } | |
| 23 | ||
| 20 | 24 | $dotenv = \Dotenv\Dotenv::createImmutable(dirname(__DIR__)); |
| 21 | 25 | $dotenv->load(); |
| 22 | 26 | } |