ReviewOS

also looking at this

meemalabs/laravel-media-converter

[1.0] Introducing the "Simple Usage" API

#14
Merged chris wants to merge v1.0 into main
10 files +406 -200

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/test.yml .github/workflows/run-tests.ymlrenamed+14-12
Changes to .github/workflows/run-tests.yml
@@ -1,9 +1,11 @@
1name: Test
1name: Run Tests
22
3on: [push]
3on:
4 push:
5 pull_request:
46
57jobs:
6 test:
8 run-tests:
79 runs-on: ubuntu-latest
810 strategy:
911 fail-fast: false
@@ -21,20 +23,13 @@ jobs:
2123
2224 steps:
2325 - name: Checkout code
24 uses: actions/checkout@v1
26 uses: actions/checkout@v2
2527
2628 - name: Setup PHP
2729 uses: shivammathur/setup-php@v2
2830 with:
2931 php-version: ${{ matrix.php }}
3032 extensions: mbstring, intl, pdo, pdo_sqlite, sqlite, curl
31 env:
32 AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
33 AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
34 AWS_DEFAULT_REGION: 'us-east-1'
35 AWS_MEDIACONVERT_ACCOUNT_URL: ${{ secrets.AWS_MEDIACONVERT_ACCOUNT_URL }}
36 AWS_IAM_ARN: ${{ secrets.AWS_IAM_ARN }}
37 AWS_QUEUE_ARN: ${{ secrets.AWS_QUEUE_ARN }}
3833
3934 - name: Cache dependencies
4035 uses: actions/cache@v1
@@ -44,7 +39,7 @@ jobs:
4439
4540 - name: Install dependencies
4641 run: |
47 composer require "orchestra/testbench:$" --no-interaction --no-update
42 composer require "laravel/framework:$" "orchestra/testbench:$" --no-interaction --no-update
4843 composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
4944
5045 - name: Create .env file
@@ -52,3 +47,10 @@ jobs:
5247
5348 - name: Execute tests
5449 run: vendor/bin/pest
50 env:
51 AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
52 AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
53 AWS_DEFAULT_REGION: 'us-east-1'
54 AWS_MEDIACONVERT_ACCOUNT_URL: ${{ secrets.AWS_MEDIACONVERT_ACCOUNT_URL }}
55 AWS_IAM_ARN: ${{ secrets.AWS_IAM_ARN }}
56 AWS_QUEUE_ARN: ${{ secrets.AWS_QUEUE_ARN }}