ReviewOS

also looking at this

meemalabs/laravel-media-converter

[1.0] Implement GitHub actions to run Pest test suite

#13
Merged chris wants to merge github-actions into main
3 files +14 -3

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

tests/MediaConverterTestCase.phpmodified+8-0
Changes to tests/MediaConverterTestCase.php
@@ -2,6 +2,7 @@
22
33namespace Meema\MediaConverter\Tests;
44
5use Illuminate\Support\Facades\Config;
56use Meema\MediaConverter\Providers\MediaConverterServiceProvider;
67use Orchestra\Testbench\TestCase;
78
@@ -26,6 +27,13 @@ class MediaConverterTestCase extends TestCase
2627 {
2728 $configFile = file_get_contents(__DIR__.'/config/job.json');
2829
30 // let's make sure these config values are set
31 Config::set('media-converter.credentials.key', env('AWS_ACCESS_KEY_ID'));
32 Config::set('media-converter.credentials.secret', env('AWS_SECRET_ACCESS_KEY'));
33 Config::set('media-converter.url', env('AWS_MEDIACONVERT_ACCOUNT_URL'));
34 Config::set('media-converter.iam_arn', env('AWS_IAM_ARN'));
35 Config::set('media-converter.queue_arn', env('AWS_QUEUE_ARN'));
36
2937 $this->settings = json_decode($configFile, true);
3038 }
3139}