ReviewOS

also looking at this

meemalabs/laravel-media-converter

Apply fixes from StyleCI

#11
Merged glennmichael123 wants to merge analysis-lK3kxr into main
2 files +11 -11

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

tests/MediaConverterTest.phpmodifiedformatting only+9-9
Changes to tests/MediaConverterTest.php
@@ -15,9 +15,9 @@ it('it can successfully initialize settings', function () {
1515});
1616
1717it('it can successfully create a job', function () {
18 $response = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []);
18 $response = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []);
1919
20 $this->assertEquals($response['@metadata']['statusCode'], 201);
20 $this->assertEquals($response['@metadata']['statusCode'], 201);
2121});
2222
2323it('it can successfully get a job', function () {
@@ -28,19 +28,19 @@ it('it can successfully get a job', function () {
2828
2929 $this->assertEquals($response['@metadata']['statusCode'], 200);
3030 $this->assertEquals($response['Job']['Id'], $jobId);
31 });
31});
3232
3333 it('it can successfully cancel a job', function () {
34 $job = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []);
34 $job = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []);
3535
36 $response = Meema\MediaConverter\Facades\MediaConvert::cancelJob($job['Job']['Id']);
36 $response = Meema\MediaConverter\Facades\MediaConvert::cancelJob($job['Job']['Id']);
3737
38 $this->assertEquals($response['@metadata']['statusCode'], 202);
38 $this->assertEquals($response['@metadata']['statusCode'], 202);
3939 });
4040
4141 it('it can successfully list jobs', function () {
42 $response = Meema\MediaConverter\Facades\MediaConvert::listJobs([]);
42 $response = Meema\MediaConverter\Facades\MediaConvert::listJobs([]);
4343
44 $this->assertEquals($response['@metadata']['statusCode'], 200);
45 $this->assertTrue(count($response) > 0);
44 $this->assertEquals($response['@metadata']['statusCode'], 200);
45 $this->assertTrue(count($response) > 0);
4646 });
tests/MediaConverterTestCase.phpmodifiedformatting only+2-2
Changes to tests/MediaConverterTestCase.php
@@ -24,7 +24,7 @@ class MediaConverterTestCase extends TestCase
2424
2525 public function setDestination()
2626 {
27 $config = config('media-converter.settings');
27 $config = config('media-converter.settings');
2828 $this->settings = $config;
2929
3030 $destination = 's3://meema-stage/';
@@ -41,7 +41,7 @@ class MediaConverterTestCase extends TestCase
4141 $this->settings['Inputs'][0]['FileInput'] = $fileDestination;
4242 }
4343
44 /**
44 /**
4545 * @see https://docs.aws.amazon.com/mediaconvert/latest/ug/cbr-vbr-qvbr.html?icmpid=docs_mediaconvert_errormsg
4646 */
4747 public function setQvbrSettings()