also looking at this
meemalabs/laravel-media-converter
Apply fixes from StyleCI
#11
2 files
+11
-11
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -15,9 +15,9 @@ it('it can successfully initialize settings', function () { | ||
| 15 | 15 | }); |
| 16 | 16 | |
| 17 | 17 | it('it can successfully create a job', function () { |
| 18 | $response = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []); | |
| 18 | $response = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []); | |
| 19 | 19 | |
| 20 | $this->assertEquals($response['@metadata']['statusCode'], 201); | |
| 20 | $this->assertEquals($response['@metadata']['statusCode'], 201); | |
| 21 | 21 | }); |
| 22 | 22 | |
| 23 | 23 | it('it can successfully get a job', function () { |
| @@ -28,19 +28,19 @@ it('it can successfully get a job', function () { | ||
| 28 | 28 | |
| 29 | 29 | $this->assertEquals($response['@metadata']['statusCode'], 200); |
| 30 | 30 | $this->assertEquals($response['Job']['Id'], $jobId); |
| 31 | }); | |
| 31 | }); | |
| 32 | 32 | |
| 33 | 33 | it('it can successfully cancel a job', function () { |
| 34 | $job = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []); | |
| 34 | $job = Meema\MediaConverter\Facades\MediaConvert::createJob($this->settings, []); | |
| 35 | 35 | |
| 36 | $response = Meema\MediaConverter\Facades\MediaConvert::cancelJob($job['Job']['Id']); | |
| 36 | $response = Meema\MediaConverter\Facades\MediaConvert::cancelJob($job['Job']['Id']); | |
| 37 | 37 | |
| 38 | $this->assertEquals($response['@metadata']['statusCode'], 202); | |
| 38 | $this->assertEquals($response['@metadata']['statusCode'], 202); | |
| 39 | 39 | }); |
| 40 | 40 | |
| 41 | 41 | it('it can successfully list jobs', function () { |
| 42 | $response = Meema\MediaConverter\Facades\MediaConvert::listJobs([]); | |
| 42 | $response = Meema\MediaConverter\Facades\MediaConvert::listJobs([]); | |
| 43 | 43 | |
| 44 | $this->assertEquals($response['@metadata']['statusCode'], 200); | |
| 45 | $this->assertTrue(count($response) > 0); | |
| 44 | $this->assertEquals($response['@metadata']['statusCode'], 200); | |
| 45 | $this->assertTrue(count($response) > 0); | |
| 46 | 46 | }); |
| @@ -24,7 +24,7 @@ class MediaConverterTestCase extends TestCase | ||
| 24 | 24 | |
| 25 | 25 | public function setDestination() |
| 26 | 26 | { |
| 27 | $config = config('media-converter.settings'); | |
| 27 | $config = config('media-converter.settings'); | |
| 28 | 28 | $this->settings = $config; |
| 29 | 29 | |
| 30 | 30 | $destination = 's3://meema-stage/'; |
| @@ -41,7 +41,7 @@ class MediaConverterTestCase extends TestCase | ||
| 41 | 41 | $this->settings['Inputs'][0]['FileInput'] = $fileDestination; |
| 42 | 42 | } |
| 43 | 43 | |
| 44 | /** | |
| 44 | /** | |
| 45 | 45 | * @see https://docs.aws.amazon.com/mediaconvert/latest/ug/cbr-vbr-qvbr.html?icmpid=docs_mediaconvert_errormsg |
| 46 | 46 | */ |
| 47 | 47 | public function setQvbrSettings() |