ReviewOS

also looking at this

loghqorg/loghq

Deploy: GitHub sign-in credentials, auth helper move, callback defaults

#9
Merged glennmichael123 wants to merge main into production
10 files +15 -12
9 days ago

Promotes four commits from main to production, which is loghq's deploy branch.

commitwhat
feat(auth)GitHub sign-in credentials (this is the one that matters)
fix(auth)OAuth callback defaults pointed at the real /api/auth/{provider}/callback route
refactor(actions)authCookie.ts moved from app/Actions/Auth/ to app/Support/
docs(auth)the prose references that followed it

GitHub sign-in

/api/auth/github/redirect currently returns 503 github sign-in is not configured yet - what SocialRedirectAction returns when socialConfigured() finds no client id or secret. This sets all three values from a newly registered OAuth app.

Callback registered with GitHub: https://loghq.org/api/auth/github/callback

Verified by shape before committing: public key header intact, all 38 values encrypted:v2, no plaintext. Not verified with buddy env:decrypt - that command rewrites the file in place and strips the header, which is how a client secret reached a commit in bughq earlier today. That secret has been revoked.

The helper move

app/Actions/ is the routing surface, and authCookie.ts is shared logic used by five actions rather than an endpoint. Moved with its importers in one commit. Lint, typecheck and 516 tests passed on main.

After merge

curl -sS -o /dev/null -w '%{http_code}\n' https://loghq.org/api/auth/github/redirect

302 to github.com/login/oauth/authorize means sign-in is live. That would make it four of four: analyticshq, statushq and bughq are already returning 302.

10 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.