ReviewOS

also looking at this

loghqorg/loghq

Deploy: GitHub sign-in credentials, auth helper move, callback defaults

#9
Merged glennmichael123 wants to merge main into production
10 files +15 -12

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

config/services.tsmodified+3-3
Changes to config/services.ts
@@ -54,21 +54,21 @@ export default {
5454 teamId: String(env.APPLE_TEAM_ID || ''),
5555 keyId: String(env.APPLE_KEY_ID || ''),
5656 privateKey: String(env.APPLE_PRIVATE_KEY || ''), // literal \n newlines allowed
57 redirectUrl: String(env.APPLE_REDIRECT_URL || 'http://localhost:3000/auth/apple/callback'),
57 redirectUrl: String(env.APPLE_REDIRECT_URL || `${oauthBase()}/api/auth/apple/callback`),
5858 scopes: ['name', 'email'],
5959 },
6060
6161 facebook: {
6262 clientId: String(env.FACEBOOK_CLIENT_ID || ''),
6363 clientSecret: String(env.FACEBOOK_CLIENT_SECRET || ''),
64 redirectUrl: String(env.FACEBOOK_REDIRECT_URL || 'http://localhost:3000/auth/facebook/callback'),
64 redirectUrl: String(env.FACEBOOK_REDIRECT_URL || `${oauthBase()}/api/auth/facebook/callback`),
6565 scopes: ['email', 'public_profile'],
6666 },
6767
6868 twitter: {
6969 clientId: String(env.TWITTER_CLIENT_ID || ''),
7070 clientSecret: String(env.TWITTER_CLIENT_SECRET || ''),
71 redirectUrl: String(env.TWITTER_REDIRECT_URL || 'http://localhost:3000/auth/twitter/callback'),
71 redirectUrl: String(env.TWITTER_REDIRECT_URL || `${oauthBase()}/api/auth/twitter/callback`),
7272 scopes: ['tweet.read', 'users.read', 'offline.access'],
7373 },
7474