ReviewOS

also looking at this

loghqorg/loghq

Promote main to production: signed-out chrome and the subscriber tables

#17
Merged glennmichael123 wants to merge main into production
54 files +4252 -1353

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

resources/partials/SiteFooter.stxmodified+16-6
Changes to resources/partials/SiteFooter.stx
@@ -14,12 +14,22 @@ const footerYear = new Date().getFullYear()
1414
1515<footer class="footer shell">
1616 {{-- The two source rules were `@media (max-width: 900px)` and
17 `(max-width: 560px)`. Crosswind emits nothing for a max-width
18 variant, so this is the same design stated mobile-first: one column
19 by default, two from bp-sm (561px), the 1.4fr lead column from bp-md
20 (901px). The breakpoints are declared in config/crosswind.ts and sit
21 one pixel above the max-widths they replace, which is what keeps the
22 boundaries identical. --}}
17 `(max-width: 560px)`, restated mobile-first: one column by default, two
18 from bp-sm (561px), the 1.4fr lead column from bp-md (901px). The
19 breakpoints are declared in config/crosswind.ts and sit one pixel above
20 the max-widths they replace, which is what keeps the boundaries
21 identical.
22
23 This used to say crosswind emits nothing for a max-width variant, which
24 is not true and misled a reader into thinking the direction was
25 unavailable. Measured on 0.3.8, which this app runs: `max-md:` and
26 `max-sm:` both emit their `@media (max-width: …)` correctly. What emits
27 nothing is the ARBITRARY form, `max-[560px]:` -- and 560 and 900 are not
28 on any scale, so that is the one this footer would have needed.
29
30 It stays mobile-first regardless. Min-width is the better default for a
31 layout that grows, and the named breakpoints say what they mean where a
32 pair of arbitrary max-widths did not. --}}
2333 <div class="grid gap-x-8 gap-y-7 grid-cols-1 bp-md:gap-x-10 bp-md:gap-y-8 bp-md:grid-cols-[1.4fr_1fr_1fr_1fr] bp-sm:grid-cols-2 pb-9 pt-4 footer-cols">
2434 <div class="flex flex-col gap-[0.6rem] footer-col">
2535 <h4 class="footer-head">Product</h4>