ReviewOS

also looking at this

loghqorg/loghq

Promote main to production: signed-out chrome and the subscriber tables

#17
Merged glennmichael123 wants to merge main into production
54 files +4252 -1353

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/ci.ymlmodified+9-3
Changes to .github/workflows/ci.yml
@@ -96,9 +96,15 @@ jobs:
9696 # the count down, then delete `continue-on-error` and add the grep that
9797 # fails on anything but "0 error(s), 0 warning(s)".
9898 #
99 # When that happens, note that --lib must be a SINGLE file: the checker
100 # does not read ambient types from tsconfig `include`, and repeating the
101 # flag silently drops all but the last (stacksjs/stx#1926).
99 # When that happens: --lib is required, because the checker does not read
100 # ambient types from tsconfig `include`. It may be REPEATED, so the
101 # declarations do not have to be crammed into one file.
102 # stacksjs/stx#1926, where all but the last flag were silently dropped,
103 # is fixed. Verified on this repo's own installed stx (0.2.532) with two
104 # .d.ts files each declaring one global: both passed resolves both, and
105 # passing only the first fails with `Cannot find name 'betaGlobal'`,
106 # which is the control that proves the checker ran at all.
107 # stacksjs/analyticshq passes six --lib flags in CI today.
102108 - name: Typecheck .stx (advisory)
103109 continue-on-error: true
104110 run: bunx --bun stx typecheck 'resources/**/*.stx'