also looking at this
Promote main to production: signed-out chrome and the subscriber tables
#17
54 files
+4252
-1353
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -63,8 +63,18 @@ const DEV_PASSWORD = 'stacks-dev-only' | ||
| 63 | 63 | const DEV_NAME = 'LogHQ Owner' |
| 64 | 64 | const PROJECT_NAME = 'LogHQ' |
| 65 | 65 | |
| 66 | /** APP_ENV values that may use the fallback credentials above. */ | |
| 67 | const LOCAL_ENVS = new Set(['development', 'local', 'test', 'testing']) | |
| 66 | /** | |
| 67 | * APP_ENV values that may use the fallback credentials above. | |
| 68 | * | |
| 69 | * `dev` is in here deliberately: config/env.ts types APP_ENV as the enum | |
| 70 | * local|dev|stage|prod, so `dev` is a value this app really takes even though | |
| 71 | * the committed .env says `development`. Without it the seeder would silently | |
| 72 | * skip on a correctly-configured machine and report success while writing | |
| 73 | * nothing. `stage` is deliberately NOT here -- it falls through to the | |
| 74 | * "supply the password" branch, which is the point of listing the local | |
| 75 | * values explicitly instead of testing for "not production". | |
| 76 | */ | |
| 77 | const LOCAL_ENVS = new Set(['development', 'dev', 'local', 'test', 'testing']) | |
| 68 | 78 | const PRODUCTION_ENVS = new Set(['prod', 'production']) |
| 69 | 79 | |
| 70 | 80 | /** |