ReviewOS

also looking at this

loghqorg/loghq

refactor(ui): use shared auth submit buttons

#13
Merged glennmichael123 wants to merge refactor/loghq-shared-controls into main
4 files +74 -3
9 days ago

Summary

  • Replace repeated sign-in, two-factor, and registration submit controls with the installed Stacks Button component.
  • Preserve the current 40px height, full width, colors, hover treatment, labels, and disabled appearance via a scoped Crosswind shortcut.
  • Keep all auth endpoints, form fields, and handlers unchanged.
  • Add rendering and generated-CSS regression coverage.

Verification

  • Targeted rendering and theme tests: 4 passed, 120 assertions.
  • Pickier, typecheck, UI template validation, and diff checks passed.
  • Production build compiled 38 routes. Existing warnings remain for the projects/new import path and analytics unmatched divs; neither is changed here.
  • Chrome UI-only preview checked at 375x812 and 1280x900 in light and dark modes, including keyboard focus and no horizontal overflow.
  • Simulated responses verified sign-in pending state, transition to 2FA, verification error recovery, and registration pending/error recovery. No real accounts, database writes, or email were involved.
  • Submit text contrast: 5.48:1 light, 9.83:1 dark.

Scope

First component-adoption batch only. This does not claim authenticated production QA. Separate from the pending E2E-safety PR #12. Do not merge or deploy without approval.

4 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.