ReviewOS

home-lang/home

Preserve upstream Node URL and inspect test accounting

#607
Closed chris opened this 9 days ago ·
9 days ago

Remove nine corpus source rewrites that currently promote upstream test.todo, test.skip, and describe.todo declarations into active tests.

Scope:

  • delete rewriteUrlParseQueryCorpus
  • delete rewriteNodeUrlCanParseCorpus
  • delete rewriteNodeUrlFormatInvalidInputCorpus
  • delete rewriteNodeUrlPathToFileUrlCorpus
  • delete rewriteNodeUrlFileUrlToPathCorpus
  • delete rewriteNodeUrlRevokeObjectUrlCorpus
  • delete rewriteNodeUrlNullCharCorpus
  • delete rewriteNodeUrlIsUrlCorpus
  • delete rewriteNodeInternalInspectCorpus
  • route all nine vendored files unchanged and update corpus expectations to preserve their upstream TODO/skip status

Pinned baseline at Bun 4982b91e3 for the combined unchanged set: 6 pass / 3 skip / 7 TODO / 0 fail. Home strict native execution already matches that baseline exactly.

Acceptance:

  • fixtures remain byte-for-byte identical to Bun
  • no source rewrite activates an upstream-deferred test
  • Debug and ReleaseSafe strict/routed counts match pinned Bun
  • zero failures and zero unsupported tests
  • update #202 and #66 after landing
9 days ago

Completed in 63fbba675.

Deleted all nine scoped rewrite functions and preserved the original upstream test.todo, test.skip, and describe.todo registrations. Updated every duplicated corpus expectation to the exact per-file upstream accounting.

Validation against pinned Bun 4982b91e3:

  • pinned Bun combined: 6 pass / 3 skip / 7 TODO / 0 fail
  • Home Debug strict: 6 pass / 3 skip / 7 TODO / 0 fail
  • Home Debug routed: 6 pass / 10 deferred / 0 fail / 0 unsupported
  • Home ReleaseSafe strict: 6 pass / 3 skip / 7 TODO / 0 fail
  • Home ReleaseSafe routed: 6 pass / 10 deferred / 0 fail / 0 unsupported
  • the reduced routed summary intentionally combines upstream skip and TODO registrations in its TODO counter
  • all nine vendored files are byte-for-byte identical to the pinned Bun checkout
  • the updated home_test unit executable compiled and linked successfully; its known resource-heavy full-corpus execution was not duplicated after the focused Debug/ReleaseSafe matrices

No fixtures, assertions, timeouts, or runtime behavior were weakened.

Sign in to comment on this issue.