ReviewOS

home-lang/home

Port Stripe charge retrieval corpus surface

#310
Closed chris opened this 10 days ago ·
10 days ago

Bun compatibility slice

Port js/third_party/stripe/stripe.test.ts at exhaustive corpus position 4063.

Required behavior

  • expose the named Stripe constructor and charge retrieval promise surface;
  • preserve Bun's secret-gated todo when TEST_INFO_STRIPE is unavailable;
  • return Stripe-shaped resource-missing errors for charge retrieval;
  • retain operation, parameter, status, request, and causal stack context without exposing API keys or connected-account IDs;
  • add the upstream fixture and a permanent redaction/error regression to the matrix.

Tracked from #66.

10 days ago

Implemented and pushed in 7ca1c4cac.

Coverage now includes:

  • named and default Stripe constructor exports;
  • Stripe.errors.StripeInvalidRequestError and instance-correct charge retrieval rejections;
  • Stripe-shaped resource_missing, id, 404, request ID, and raw error fields;
  • stripe.charges.retrieve operation and causal stack context;
  • API-key and connected-account redaction from messages and stacks;
  • preservation of Bun's secret-gated upstream todo when credentials are unavailable.

Verification:

  • focused position 4063: 1 file, 0 failed, 1 todo, 0 unsupported/allowed-empty;
  • positions 4062–4063: 2 files, 1 passed, 1 intentional todo, 0 failed/unsupported/allowed-empty;
  • permanent gRPC error-stack, SQL adapter-contract, third-party corpus, and 41-case behavior/error diagnostic suites all pass.

Sign in to comment on this issue.