ReviewOS

home-lang/home

Port jsonwebtoken complete verification results

#275
Closed chris opened this 11 days ago ·
11 days ago

Scope

Confirm permanently covered positions 4023–4024 and port Bun corpus position 4025, js/third_party/jsonwebtoken/option-complete.test.js.

Acceptance criteria

  • jwt.verify(..., { complete: true }) returns the verified header, payload, and original signature.
  • complete: false and omitted complete options continue returning only the payload.
  • Synchronous and callback verification results remain identical.
  • Existing key-family, signature, claim, and structured error behavior does not regress.
  • Focused, adjacent JWT, and permanent mini-suite diagnostics pass.
11 days ago

Completed in 4de240928 and pushed to main.

Bun corpus positions 4023–4024 remain green and permanently covered (noTimestamp 1/1, non-object values 2/2). Position 4025, option-complete.test.js, is fully ported at 2/2: verified complete: true calls return { header, payload, signature }, while complete: false and normal calls return only the payload. Sync/callback parity remains enforced.

Verification:

  • positions 4023–4025: 5/5
  • permanent third-party diagnostic contracts: 15/15
  • full third-party JWT/utility mini-suite: passed
  • formatting and diff checks: passed

Sign in to comment on this issue.