ReviewOS

home-lang/home

Restore ResolvedSource tags to the actually linked Bun registry

#123
Closed chris opened this 9 days ago ·
9 days ago

The main update f33c52e changed ResolvedSource.Tag to ids 610/619/650/661 for node:fs/node:path/bun:test/bun, but the artifact Home actually links is /Users/chris/Code/bun/build/release/obj and its adjacent generated registry /Users/chris/Code/bun/build/release/codegen/generated_resolved_source_tag.rs maps those modules to 628/637/670/681.

Observed regression after integrating f33c52e:

  • full home_test: 7 failures (bun:test named exports missing, fs.promises missing, plugin namespace, spawnSync isolation)
  • exact issue-6874 harness-only files still pass
  • prior full gate passed with the generated registry ids

Scope:

  • restore ResolvedSource.Tag verbatim from the generated registry adjacent to the linked object root
  • pin representative inserted modules and native module ids in tests
  • rebuild and verify native bun:test/node:fs subprocess behavior
  • restore the full home_test gate

Related port tracker: #66 Blocked focused tranche: #122

9 days ago

Implemented and pushed in 456898e.

The runtime tag table now matches the generated ResolvedSource registry adjacent to the Bun object root actually linked by Home. Verification covered all 170 generated registry IDs; the sole generated alias, @vercel/fetch, intentionally shares the vercel_fetch ID. The independent node:fs flag correction from f33c52e remains intact.

Integrated validation at the pushed tip:

  • mock/6874/A.test.ts: 1 pass, 0 fail/todo/unsupported
  • mock/6874/B.test.ts: 1 pass, 0 fail/todo/unsupported
  • stack.test.ts: 6 pass, 1 upstream todo, 0 fail/unsupported
  • full home_test gate: all 1,095 cases completed with the one expected skip and no failures

This removes the ABI regression that blocked #122 and restores the runtime surface needed by #66.

Sign in to comment on this issue.