ReviewOS

also looking at this

craft-native/craft

iOS Phase 8: the presented pickers — ratchet 58 → 53, last mechanism landed

#90
Merged glennmichael123 wants to merge feat/ios-phase8-ui into main
11 files +5752 -12
packages/zig/src/bridge_mobile_system.zigmodified+3-3
Changes to packages/zig/src/bridge_mobile_system.zig
@@ -355,7 +355,7 @@ fn failFromCallback(request_id: i64, action: []const u8, err: bridge_error.Bridg
355355/// The non-Darwin arm is not a stub that pretends to work — it returns
356356/// `error.UnsupportedPlatform`, which `ios_dispatch.asBridgeError` turns into
357357/// `PLATFORM_NOT_SUPPORTED` for the page.
358const uikit = if (is_darwin) struct {
358pub const uikit = if (is_darwin) struct {
359359 /// `[[UIApplication sharedApplication] openURL:options:completionHandler:]`
360360 ///
361361 /// The modern three-argument selector, never the deprecated one-argument
@@ -554,7 +554,7 @@ const uikit = if (is_darwin) struct {
554554 /// draws no arrow. It is emphatically not `UIPopoverArrowDirectionUnknown`,
555555 /// which is `NSUIntegerMax`: passing that would permit every direction and
556556 /// point an arrow at the middle of the screen.
557 fn anchorPopover(activity_vc: objc.id, presenter: objc.id) !void {
557 pub fn anchorPopover(activity_vc: objc.id, presenter: objc.id) !void {
558558 const sel_popover = objc.sel_registerName("popoverPresentationController") orelse
559559 return error.SelectorNotFound;
560560 const popover = objc.msgSendId(activity_vc, sel_popover);
@@ -669,7 +669,7 @@ const uikit = if (is_darwin) struct {
669669 /// presenting on a controller that is already presenting something logs
670670 /// "which is already presenting" and silently does nothing, so the
671671 /// completion handler never fires and the caller waits out its timeout.
672 fn topmostViewController() !objc.id {
672 pub fn topmostViewController() !objc.id {
673673 const webview = ios_dispatch.getWebView() orelse
674674 return bridge_error.BridgeError.WebViewHandleNotSet;
675675 if (webview == null) return bridge_error.BridgeError.WebViewHandleNotSet;