also looking at this

fix(ci): let the benchmark job comment on pull requests

#41

Merged glennmichael123 wants to merge fix/benchmark-pr-comment-permission into main

1 file +10 -0

glennmichael123 11 days ago

The Benchmark job fails on every pull request, at the very last step:

RequestError [HttpError]: Resource not accessible by integration
##[error]Unhandled error: HttpError: Resource not accessible by integration

It posts its comparison as a PR comment, and the default GITHUB_TOKEN is read-only. The build ran, every benchmark ran, the comparison was computed — and then the job went red over permission to leave a comment.

Only pull requests comment, so pushes to main stayed green and the job looked healthy. That is why this outlived the identical bug in binary-size.yml, fixed in #22 — same cause, same fix, one workflow missed.

benchmarks.yml and binary-size.yml are the only two workflows here that call github-script, and binary-size.yml is now the only one that declares the permission. After this they match.

Requested explicitly rather than left to the repository default, for the same reason as #22: the default is what made it invisible.

1 changed file on the files tab, with 0 review threads.