also looking at this
fix(native): interaction, audio, document and checkpoint gaps stranded after #401
#415
19 files
+987
-50
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -198,6 +198,10 @@ describe('Craft Android builder', () => { | ||
| 198 | 198 | expect(refreshableFlatList).toContain('isRefreshing = false') |
| 199 | 199 | expect(flatList).toContain('fun setKeyboardDismissMode(mode: String, dismissKeyboard: () -> Unit)') |
| 200 | 200 | expect(nativeActivity).toContain('setKeyboardDismissMode(craftNativeOptionalString(props.opt("keyboardDismissMode")).orEmpty())') |
| 201 | expect(nativeActivity).toContain('private val frameCallback = android.view.Choreographer.FrameCallback') | |
| 202 | expect(nativeActivity).toContain('android.view.Choreographer.getInstance().postFrameCallback(frameCallback)') | |
| 203 | expect(nativeActivity).toContain('android.view.Choreographer.getInstance().removeFrameCallback(frameCallback)') | |
| 204 | expect(nativeActivity).toContain('requestAnimationFrame') | |
| 201 | 205 | expect(flatList).toContain('renderedLayout?.height ?: LayoutParams.WRAP_CONTENT') |
| 202 | 206 | expect(nativeActivity).toContain('val nestedLists = refreshableLists.map { it.list }.toSet()') |
| 203 | 207 | expect(nativeActivity).toContain('released.addAll(nestedLists)') |
| @@ -249,6 +249,10 @@ describe('Craft iOS builder', () => { | ||
| 249 | 249 | expect(nativeSwift).toContain('UIApplication.didBecomeActiveNotification') |
| 250 | 250 | expect(nativeSwift).toContain('DeepLinkManager.shared.addNativeListener') |
| 251 | 251 | expect(nativeSwift).toContain('navigationController?.topViewController === self') |
| 252 | expect(nativeSwift).toContain('final class CraftNativeFrameClock: NSObject') | |
| 253 | expect(nativeSwift).toContain('let link = CADisplayLink(target: self, selector: #selector(frame(_:)))') | |
| 254 | expect(nativeSwift).toContain('link.add(to: .main, forMode: .common)') | |
| 255 | expect(nativeSwift).toContain('if waiting.isEmpty { link.isPaused = true }') | |
| 252 | 256 | expect(nativeSwift).toContain('private class CraftNativeFlowView: UIStackView') |
| 253 | 257 | expect(nativeSwift).toContain('let frameCount = output.count') |
| 254 | 258 | expect(nativeSwift).toContain('private func sharedTreeFrames(') |