ReviewOS

also looking at this

craft-native/craft

fix(native): interaction, audio, document and checkpoint gaps stranded after #401

#415
Merged glennmichael123 wants to merge codex/issues-388-400-344 into main
19 files +987 -50

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

scripts/native-renderer-contract.test.tsmodified+1-1
Changes to scripts/native-renderer-contract.test.ts
@@ -4151,7 +4151,7 @@ describe('native renderer component contract', () => {
41514151 expect(androidCapabilities).toContain('CRAFT_NATIVE_FILE_ERROR_BODY_BYTES = 64 * 1024')
41524152 expect(androidCapabilities).toContain('private fun sweepFiles()')
41534153 expect(androidCapabilities).not.toContain('fileRoot.deleteRecursively()')
4154 expect(androidCapabilities).toContain('private fun writeImage(bitmap: Bitmap, maxPixels: Int, quality: Float, name: String): JSONObject?')
4154 expect(androidCapabilities).toContain('private fun writeImage(bitmap: Bitmap, maxPixels: Int, quality: Float, name: String, requestToken: String? = null): JSONObject?')
41554155 expect(androidCapabilities).toContain('CRAFT_NATIVE_FILE_DEFAULT_MAX_PIXELS = 2048')
41564156 expect(android).toContain('capabilities.onActivityResult(requestCode, resultCode, data)')
41574157 })