also looking at this
feat: finish native customization and platform seams
#401
21 files
+707
-17
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -91,6 +91,7 @@ describe('Craft iOS builder', () => { | ||
| 91 | 91 | expect(swift).toContain('private(set) var tabSelectionColor: UIColor?') |
| 92 | 92 | expect(swift).toContain('appearance: CraftConfig.TabBar? = nil') |
| 93 | 93 | expect(swift).toContain('chrome.tabSelectionColor.map { Color($0) }') |
| 94 | expect(swift).toContain('@ObservedObject private var chrome = CraftChrome.shared') | |
| 94 | 95 | expect(hybrid).toContain('appearance: config.tabBar') |
| 95 | 96 | await expect(init({ name: 'Invalid Tab Bar', output: join(output, 'invalid'), runtimeDir: null, config: { |
| 96 | 97 | tabBar: { selection: { cornerRadius: -1 } }, |
| @@ -1321,6 +1321,7 @@ private struct CraftTabSelectionShape: Shape { | ||
| 1321 | 1321 | } |
| 1322 | 1322 | |
| 1323 | 1323 | private struct CraftTabSelectionIndicator: View { |
| 1324 | @ObservedObject private var chrome = CraftChrome.shared | |
| 1324 | 1325 | @ObservedObject private var progress = CraftChrome.shared.tabSwipeProgress |
| 1325 | 1326 | let selected: Int? |
| 1326 | 1327 | let count: Int |